diff options
| author | Raul Tambre <raul@tambre.ee> | 2019-05-04 15:48:17 -0400 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@polymtl.ca> | 2019-05-04 15:52:20 -0400 |
| commit | b6484282f85bf7f11451b2441599c241d302ad9d (patch) | |
| tree | 537ace90ed6dae2dd8a71403df15d257eb19639b | |
| parent | af97b4161f07a716783183f1b17fa5cac9f99a49 (diff) | |
| download | gdb-b6484282f85bf7f11451b2441599c241d302ad9d.zip gdb-b6484282f85bf7f11451b2441599c241d302ad9d.tar.gz gdb-b6484282f85bf7f11451b2441599c241d302ad9d.tar.bz2 | |
Fix incorrect use of 'is' operator for comparison in python/lib/gdb/command/prompt.py
The 'is' operator is not meant to be used for comparisons. It currently working
is an implementation detail of CPython. CPython 3.8 has added a SyntaxWarning
for this.
| -rw-r--r-- | gdb/ChangeLog | 6 | ||||
| -rw-r--r-- | gdb/python/lib/gdb/command/prompt.py | 4 |
2 files changed, 8 insertions, 2 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 383b353..7eb5d9a 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2019-05-04 Raul Tambre <raul@tambre.ee> + + * python/lib/gdb/prompt.py (_ExtendedPrompt) + <before_prompt_hook, get_show_string>: Fix incorrect use of 'is' + operator for comparison. + 2019-05-04 Tom Tromey <tom@tromey.com> * psymtab.c (psymbol_name_matches, match_partial_symbol) diff --git a/gdb/python/lib/gdb/command/prompt.py b/gdb/python/lib/gdb/command/prompt.py index 3d662a7..04b9e49 100644 --- a/gdb/python/lib/gdb/command/prompt.py +++ b/gdb/python/lib/gdb/command/prompt.py @@ -45,7 +45,7 @@ The currently defined substitutions are: self.hook_set = False def get_show_string (self, pvalue): - if self.value is not '': + if self.value: return "The extended prompt is: " + self.value else: return "The extended prompt is not set." @@ -57,7 +57,7 @@ The currently defined substitutions are: return "" def before_prompt_hook(self, current): - if self.value is not '': + if self.value: return gdb.prompt.substitute_prompt(self.value) else: return None |