diff options
author | Hafiz Abid Qadeer <abidh@codesourcery.com> | 2021-02-09 17:11:28 +0000 |
---|---|---|
committer | Hafiz Abid Qadeer <abidh@codesourcery.com> | 2021-02-09 20:35:21 +0000 |
commit | b61f78118a850a28a41a461fdaea4026ddc17658 (patch) | |
tree | 152f72d521420c04b6a4d53db5872d2645ac8a17 | |
parent | f73e424f7bb51d4a5164320107f386b8fec34f4b (diff) | |
download | gdb-b61f78118a850a28a41a461fdaea4026ddc17658.zip gdb-b61f78118a850a28a41a461fdaea4026ddc17658.tar.gz gdb-b61f78118a850a28a41a461fdaea4026ddc17658.tar.bz2 |
[testsuite] Don't use 'testfile' before 'standard_testfile'.
While running tests on arm-none-eabi, I noticed following errors in some
gdb.threads tests.
ERROR: can't read "testfile": no such variable
These were being caused by ${testfile} being used before 'standard_testfile'
which sets it. This patch just moves standard_testfile before the use.
2021-02-09 Abid Qadeer <abidh@codesourcery.com>
gdb/testsuite/ChangeLog:
* gdb.threads/signal-command-handle-nopass.exp: Call
'standard_testfile' before using 'testfile'.
* gdb.threads/signal-command-multiple-signals-pending.exp: Likewise.
* gdb.threads/signal-delivered-right-thread.exp: Likewise
* gdb.threads/signal-sigtrap.exp: Likewise
5 files changed, 16 insertions, 8 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index ca011e4..e51f4d7 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,11 @@ +2021-02-09 Abid Qadeer <abidh@codesourcery.com> + + * gdb.threads/signal-command-handle-nopass.exp: Call + 'standard_testfile' before using 'testfile'. + * gdb.threads/signal-command-multiple-signals-pending.exp: Likewise. + * gdb.threads/signal-delivered-right-thread.exp: Likewise + * gdb.threads/signal-sigtrap.exp: Likewise + 2021-02-08 Luis Machado <luis.machado@linaro.org> * gdb.base/gnu-ifunc.exp (build): Pass -Wl,z,lazy. diff --git a/gdb/testsuite/gdb.threads/signal-command-handle-nopass.exp b/gdb/testsuite/gdb.threads/signal-command-handle-nopass.exp index d0ef525..bef125c 100644 --- a/gdb/testsuite/gdb.threads/signal-command-handle-nopass.exp +++ b/gdb/testsuite/gdb.threads/signal-command-handle-nopass.exp @@ -18,13 +18,13 @@ # delivered to the right thread, even if GDB has to step over a # breakpoint in some other thread first. +standard_testfile + if [target_info exists gdb,nosignals] { verbose "Skipping ${testfile}.exp because of nosignals." return -1 } -standard_testfile - if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" \ executable { debug }] != "" } { return -1 diff --git a/gdb/testsuite/gdb.threads/signal-command-multiple-signals-pending.exp b/gdb/testsuite/gdb.threads/signal-command-multiple-signals-pending.exp index d8f6f94..2d4417c 100644 --- a/gdb/testsuite/gdb.threads/signal-command-multiple-signals-pending.exp +++ b/gdb/testsuite/gdb.threads/signal-command-multiple-signals-pending.exp @@ -16,13 +16,13 @@ # Test that "signal FOO" behaves correctly when we have multiple # threads that have stopped for a signal. +standard_testfile + if [target_info exists gdb,nosignals] { verbose "Skipping ${testfile}.exp because of nosignals." return -1 } -standard_testfile - if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" \ executable { debug }] != "" } { return -1 diff --git a/gdb/testsuite/gdb.threads/signal-delivered-right-thread.exp b/gdb/testsuite/gdb.threads/signal-delivered-right-thread.exp index 6ee899b..c635fac 100644 --- a/gdb/testsuite/gdb.threads/signal-delivered-right-thread.exp +++ b/gdb/testsuite/gdb.threads/signal-delivered-right-thread.exp @@ -13,13 +13,13 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. */ +standard_testfile + if [target_info exists gdb,nosignals] { verbose "Skipping ${testfile}.exp because of nosignals." return -1 } -standard_testfile - if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" \ executable { debug }] != "" } { return -1 diff --git a/gdb/testsuite/gdb.threads/signal-sigtrap.exp b/gdb/testsuite/gdb.threads/signal-sigtrap.exp index 458bf8a..92488a5 100644 --- a/gdb/testsuite/gdb.threads/signal-sigtrap.exp +++ b/gdb/testsuite/gdb.threads/signal-sigtrap.exp @@ -16,13 +16,13 @@ # Check that GDB doesn't forget to pass SIGTRAP to the program when # the user explicitly passes it with the signal command. +standard_testfile + if [target_info exists gdb,nosignals] { verbose "Skipping ${testfile}.exp because of nosignals." return -1 } -standard_testfile - if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug pthreads}]} { return -1 } |