diff options
author | Kyrylo Tkachov <kyrylo.tkachov@arm.com> | 2019-07-23 15:54:54 +0100 |
---|---|---|
committer | Kyrylo Tkachov <kyrylo.tkachov@arm.com> | 2019-07-23 15:54:54 +0100 |
commit | a028026d2f9bbeaa2217aa8aafa1463bd88463ba (patch) | |
tree | bcd55e238e79ebbe935dd5de85b2779ce708437c | |
parent | 9a618ef61593ea5103aaf17bbe968bf552aa3de0 (diff) | |
download | gdb-a028026d2f9bbeaa2217aa8aafa1463bd88463ba.zip gdb-a028026d2f9bbeaa2217aa8aafa1463bd88463ba.tar.gz gdb-a028026d2f9bbeaa2217aa8aafa1463bd88463ba.tar.bz2 |
[AArch64] Add support for GMID_EL1 register for +memtag
We're missing support for the GMID_EL1 system register from the Memory Tagging Extension in binutils.
This is specified at:
https://developer.arm.com/docs/ddi0595/latest/aarch64-system-registers/gmid_el1
This simple patch adds the support for this read-only register.
Tested make check on gas.
-rw-r--r-- | gas/ChangeLog | 6 | ||||
-rw-r--r-- | gas/testsuite/gas/aarch64/illegal-sysreg-4.l | 1 | ||||
-rw-r--r-- | gas/testsuite/gas/aarch64/sysreg-4.d | 1 | ||||
-rw-r--r-- | gas/testsuite/gas/aarch64/sysreg-4.s | 1 | ||||
-rw-r--r-- | opcodes/ChangeLog | 5 | ||||
-rw-r--r-- | opcodes/aarch64-opc.c | 4 |
6 files changed, 17 insertions, 1 deletions
diff --git a/gas/ChangeLog b/gas/ChangeLog index 19ca464..3c363cc 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,9 @@ +2019-07-23 Kyrylo Tkachov <kyrylo.tkachov@arm.com> + + * testsuite/gas/aarch64/sysreg-4.s: Test gmid_el1 read. + * testsuite/gas/aarch64/sysreg-4.d: Update expected output. + * testsuite/gas/aarch64/illegal-sysreg-4.l: Likewise. + 2019-07-23 Alan Modra <amodra@gmail.com> * config/obj-elf.c (obj_elf_change_section): Don't emit a fatal diff --git a/gas/testsuite/gas/aarch64/illegal-sysreg-4.l b/gas/testsuite/gas/aarch64/illegal-sysreg-4.l index d431f9b..590f20e 100644 --- a/gas/testsuite/gas/aarch64/illegal-sysreg-4.l +++ b/gas/testsuite/gas/aarch64/illegal-sysreg-4.l @@ -23,6 +23,7 @@ [^:]*:[0-9]+: Error: selected processor does not support system register name 'tfsr_el12' [^:]*:[0-9]+: Error: selected processor does not support system register name 'rgsr_el1' [^:]*:[0-9]+: Error: selected processor does not support system register name 'gcr_el1' +[^:]*:[0-9]+: Error: selected processor does not support system register name 'gmid_el1' [^:]*:[0-9]+: Error: selected processor does not support PSTATE field name 'tco' [^:]*:[0-9]+: Error: selected processor does not support system register name 'tco' [^:]*:[0-9]+: Error: selected processor does not support PSTATE field name 'tco' diff --git a/gas/testsuite/gas/aarch64/sysreg-4.d b/gas/testsuite/gas/aarch64/sysreg-4.d index ab6e217..bc3d0bd 100644 --- a/gas/testsuite/gas/aarch64/sysreg-4.d +++ b/gas/testsuite/gas/aarch64/sysreg-4.d @@ -28,6 +28,7 @@ Disassembly of section \.text: .*: d53d660c mrs x12, tfsr_el12 .*: d53810a1 mrs x1, rgsr_el1 .*: d53810c3 mrs x3, gcr_el1 +.*: d5390084 mrs x4, gmid_el1 .*: d51b42e1 msr tco, x1 .*: d51b42e2 msr tco, x2 .*: d5186621 msr tfsre0_el1, x1 diff --git a/gas/testsuite/gas/aarch64/sysreg-4.s b/gas/testsuite/gas/aarch64/sysreg-4.s index 6c18b4a..ace9803 100644 --- a/gas/testsuite/gas/aarch64/sysreg-4.s +++ b/gas/testsuite/gas/aarch64/sysreg-4.s @@ -24,6 +24,7 @@ func: mrs x12, TFSR_EL12 mrs x1, rgsr_el1 mrs x3, gcr_el1 + mrs x4, gmid_el1 # MSR (register) msr tco, x1 diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog index 491c5f5..3402ddb 100644 --- a/opcodes/ChangeLog +++ b/opcodes/ChangeLog @@ -1,3 +1,8 @@ +2019-07-23 Kyrylo Tkachov <kyrylo.tkachov@arm.com> + + * aarch64-opc.c (aarch64_sys_regs): Add gmid_el1 entry. + (aarch64_sys_reg_supported_p): Handle gmid_el1 encoding. + 2019-07-22 Barnaby Wilks <barnaby.wilks@arm.com> * arm-dis.c (is_mve_unpredictable): Stop marking some MVE diff --git a/opcodes/aarch64-opc.c b/opcodes/aarch64-opc.c index 7ffec2d..a008569 100644 --- a/opcodes/aarch64-opc.c +++ b/opcodes/aarch64-opc.c @@ -3973,6 +3973,7 @@ const aarch64_sys_reg aarch64_sys_regs [] = { "tfsr_el12", CPENC(3,5,C6,C6,0), F_ARCHEXT }, { "rgsr_el1", CPENC(3,0,C1,C0,5), F_ARCHEXT }, { "gcr_el1", CPENC(3,0,C1,C0,6), F_ARCHEXT }, + { "gmid_el1", CPENC(3,1,C0,C0,4), F_ARCHEXT | F_REG_READ }, /* RO */ { "tpidr_el0", CPENC(3,3,C13,C0,2), 0 }, { "tpidrro_el0", CPENC(3,3,C13,C0,3), 0 }, /* RW */ { "tpidr_el1", CPENC(3,0,C13,C0,4), 0 }, @@ -4444,7 +4445,8 @@ aarch64_sys_reg_supported_p (const aarch64_feature_set features, || reg->value == CPENC (3, 6, C6, C6, 0) || reg->value == CPENC (3, 5, C6, C6, 0) || reg->value == CPENC (3, 0, C1, C0, 5) - || reg->value == CPENC (3, 0, C1, C0, 6)) + || reg->value == CPENC (3, 0, C1, C0, 6) + || reg->value == CPENC (3, 1, C0, C0, 4)) && !(AARCH64_CPU_HAS_FEATURE (features, AARCH64_FEATURE_MEMTAG))) return FALSE; |