diff options
| author | Pavel I. Kryukov <kryukov@frtk.ru> | 2017-10-03 22:42:07 +0300 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2017-10-04 14:24:21 +1030 |
| commit | 9ba5f27cdd15d22d6c5739ff5d2b1c81d796e114 (patch) | |
| tree | 6d6c60d6a5362a98335f92579ad1d0fa8f3c3769 | |
| parent | ca2a727a5b9389190ce86c52b0303ad8c3e2bcc6 (diff) | |
| download | gdb-9ba5f27cdd15d22d6c5739ff5d2b1c81d796e114.zip gdb-9ba5f27cdd15d22d6c5739ff5d2b1c81d796e114.tar.gz gdb-9ba5f27cdd15d22d6c5739ff5d2b1c81d796e114.tar.bz2 | |
PR22245, Fix potential UB in bfd_set_error
Passing enum as a first argument to variadic argument function
may lead to undefined behavior. The explanation on CERT site:
https://www.securecoding.cert.org/confluence/display/cplusplus/
EXP58-CPP.+Pass+an+object+of+the+correct+type+to+va_start
The bug was found by Kirill Nedostoev (nedostoev.ka@phystech.edu)
when he tried to build GNU binutils with Clang 7.
PR 22245
* bfd.c (bfd_set_error): Avoid UB on passing arg to va_start that
undergoes default promotion.
* bfd-in2.h: Regenerate.
| -rw-r--r-- | bfd/ChangeLog | 7 | ||||
| -rw-r--r-- | bfd/bfd-in2.h | 2 | ||||
| -rw-r--r-- | bfd/bfd.c | 4 |
3 files changed, 10 insertions, 3 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 9ef407c..ce948c8 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,10 @@ +2017-10-04 Pavel I. Kryukov <kryukov@frtk.ru> + + PR 22245 + * bfd.c (bfd_set_error): Avoid UB on passing arg to va_start that + undergoes default promotion. + * bfd-in2.h: Regenerate. + 2017-10-02 Alan Modra <amodra@gmail.com> * elf32-ppc.c (ppc_elf_relocate_section): Fix comment typo. diff --git a/bfd/bfd-in2.h b/bfd/bfd-in2.h index d126aed..62be566 100644 --- a/bfd/bfd-in2.h +++ b/bfd/bfd-in2.h @@ -7054,7 +7054,7 @@ bfd_error_type; bfd_error_type bfd_get_error (void); -void bfd_set_error (bfd_error_type error_tag, ...); +void bfd_set_error (int error_tag, ...); const char *bfd_errmsg (bfd_error_type error_tag); @@ -497,7 +497,7 @@ FUNCTION bfd_set_error SYNOPSIS - void bfd_set_error (bfd_error_type error_tag, ...); + void bfd_set_error (int error_tag, ...); DESCRIPTION Set the BFD error condition to be @var{error_tag}. @@ -507,7 +507,7 @@ DESCRIPTION */ void -bfd_set_error (bfd_error_type error_tag, ...) +bfd_set_error (int error_tag, ...) { bfd_error = error_tag; if (error_tag == bfd_error_on_input) |