aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Burgess <andrew.burgess@embecosm.com>2021-05-07 16:49:24 +0100
committerAndrew Burgess <andrew.burgess@embecosm.com>2021-05-07 17:00:25 +0100
commit8a82de5884386be4c10f16eb55a94993ac6ea858 (patch)
tree692aff8cc94682dff2d233f0160ad628ed4b929d
parentbedc473418aa3b595a985e4adbbeb7864c5891e3 (diff)
downloadgdb-8a82de5884386be4c10f16eb55a94993ac6ea858.zip
gdb-8a82de5884386be4c10f16eb55a94993ac6ea858.tar.gz
gdb-8a82de5884386be4c10f16eb55a94993ac6ea858.tar.bz2
gdb: some int to bool conversion
Change int parameter to bool in remote_notice_new_inferior (remote.c) and notice_new_inferior (infcmd.c), and update the callers. There should be no user visible changes after this commit. gdb/ChangeLog: * infcmd.c (notice_new_inferior): Change parameter type. * inferior.h (notice_new_inferior): Change parameter type. * remote.c (remote_notice_new_inferior): Change parameter type to bool. Also update type of local variable to bool. (remote_target::update_thread_list): Change type of local variable to bool. (remote_target::process_stop_reply): Pass bool instead of int to remote_notice_new_inferior.
-rw-r--r--gdb/ChangeLog11
-rw-r--r--gdb/infcmd.c2
-rw-r--r--gdb/inferior.h2
-rw-r--r--gdb/remote.c10
4 files changed, 18 insertions, 7 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e75eb04..9c7fdc3 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,14 @@
+2021-05-07 Andrew Burgess <andrew.burgess@embecosm.com>
+
+ * infcmd.c (notice_new_inferior): Change parameter type.
+ * inferior.h (notice_new_inferior): Change parameter type.
+ * remote.c (remote_notice_new_inferior): Change parameter type to
+ bool. Also update type of local variable to bool.
+ (remote_target::update_thread_list): Change type of local variable
+ to bool.
+ (remote_target::process_stop_reply): Pass bool instead of int to
+ remote_notice_new_inferior.
+
2021-05-07 Simon Marchi <simon.marchi@efficios.com>
* target.c (target_stack::unpush): Call target_ops::find_beneath
diff --git a/gdb/infcmd.c b/gdb/infcmd.c
index 5d9d792..f0b044d 100644
--- a/gdb/infcmd.c
+++ b/gdb/infcmd.c
@@ -2675,7 +2675,7 @@ attach_command (const char *args, int from_tty)
as stopped. */
void
-notice_new_inferior (thread_info *thr, int leave_running, int from_tty)
+notice_new_inferior (thread_info *thr, bool leave_running, int from_tty)
{
enum attach_post_wait_mode mode
= leave_running ? ATTACH_POST_WAIT_RESUME : ATTACH_POST_WAIT_NOTHING;
diff --git a/gdb/inferior.h b/gdb/inferior.h
index 4a143c3..f4b8b02 100644
--- a/gdb/inferior.h
+++ b/gdb/inferior.h
@@ -218,7 +218,7 @@ using delete_longjmp_breakpoint_cleanup
extern void detach_command (const char *, int);
-extern void notice_new_inferior (struct thread_info *, int, int);
+extern void notice_new_inferior (struct thread_info *, bool, int);
extern struct value *get_return_value (struct value *function,
struct type *value_type);
diff --git a/gdb/remote.c b/gdb/remote.c
index a7312a9..d3a6659 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -764,7 +764,7 @@ public: /* Remote specific methods. */
ptid_t select_thread_for_ambiguous_stop_reply
(const struct target_waitstatus *status);
- void remote_notice_new_inferior (ptid_t currthread, int executing);
+ void remote_notice_new_inferior (ptid_t currthread, bool executing);
void process_initial_stop_replies (int from_tty);
@@ -2556,12 +2556,12 @@ remote_target::remote_add_thread (ptid_t ptid, bool running, bool executing)
thread is (internally) executing or stopped. */
void
-remote_target::remote_notice_new_inferior (ptid_t currthread, int executing)
+remote_target::remote_notice_new_inferior (ptid_t currthread, bool executing)
{
/* In non-stop mode, we assume new found threads are (externally)
running until proven otherwise with a stop reply. In all-stop,
we can only get here if all threads are stopped. */
- int running = target_is_non_stop_p () ? 1 : 0;
+ bool running = target_is_non_stop_p ();
/* If this is a new thread, add it to GDB's thread list.
If we leave it up to WFI to do this, bad things will happen. */
@@ -3955,7 +3955,7 @@ remote_target::update_thread_list ()
executing until proven otherwise with a stop reply.
In all-stop, we can only get here if all threads are
stopped. */
- int executing = target_is_non_stop_p () ? 1 : 0;
+ bool executing = target_is_non_stop_p ();
remote_notice_new_inferior (item.ptid, executing);
@@ -8036,7 +8036,7 @@ remote_target::process_stop_reply (struct stop_reply *stop_reply,
stop_reply->regcache.clear ();
}
- remote_notice_new_inferior (ptid, 0);
+ remote_notice_new_inferior (ptid, false);
remote_thread_info *remote_thr = get_remote_thread_info (this, ptid);
remote_thr->core = stop_reply->core;
remote_thr->stop_reason = stop_reply->stop_reason;