aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Tromey <tom@tromey.com>2023-03-10 22:16:51 -0700
committerTom Tromey <tom@tromey.com>2024-01-28 10:58:16 -0700
commit8370bcc7b7b966ea86a7c87ba1549e607da7ac25 (patch)
treecf5256dd51ae09cd00d8aa3a645e4abaa4d49a2a
parentc92d4de16a0650ae973cfecf9c563893757a01f1 (diff)
downloadgdb-8370bcc7b7b966ea86a7c87ba1549e607da7ac25.zip
gdb-8370bcc7b7b966ea86a7c87ba1549e607da7ac25.tar.gz
gdb-8370bcc7b7b966ea86a7c87ba1549e607da7ac25.tar.bz2
Remove a check of VAR_DOMAIN
completion_list_add_symbol checks that the returned symbol has VAR_DOMAIN, but also checks that its address class is LOC_BLOCK. The domain check is redundant -- only functions can possibly be LOC_BLOCK -- and leaving this in place will cause a regression when combined with a later patch in this series. This patch preemptively removes the redundant check.
-rw-r--r--gdb/symtab.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/gdb/symtab.c b/gdb/symtab.c
index 7c56dba..76a771b 100644
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -5631,7 +5631,6 @@ completion_list_add_symbol (completion_tracker &tracker,
the msymbol name and removes the msymbol name from the completion
tracker. */
if (sym->language () == language_cplus
- && sym->domain () == VAR_DOMAIN
&& sym->aclass () == LOC_BLOCK)
{
/* The call to canonicalize returns the empty string if the input