aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon Marchi <simon.marchi@polymtl.ca>2022-12-02 15:09:23 -0500
committerSimon Marchi <simon.marchi@efficios.com>2022-12-05 16:38:45 -0500
commit7cc662bcb70fc4eb5a7b5883fd27fab0d4e372cb (patch)
treeaa74ffe885eefc2e130831493a9d46cbe17abda4
parent8aa1556f2e88851f9bfcacd3f624c8182946a6f6 (diff)
downloadgdb-7cc662bcb70fc4eb5a7b5883fd27fab0d4e372cb.zip
gdb-7cc662bcb70fc4eb5a7b5883fd27fab0d4e372cb.tar.gz
gdb-7cc662bcb70fc4eb5a7b5883fd27fab0d4e372cb.tar.bz2
gdb/linux-nat: check ptrace return value in linux_nat_get_siginfo
Not a big deal, but it seems strange to check errno instead of the ptrace return value to know whether it succeeded. Change-Id: If0a6d0280ab0e5ecb077e546af0d6fe489c5b9fd
-rw-r--r--gdb/linux-nat.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c
index c47b8db..b33fac3 100644
--- a/gdb/linux-nat.c
+++ b/gdb/linux-nat.c
@@ -4443,11 +4443,7 @@ bool
linux_nat_get_siginfo (ptid_t ptid, siginfo_t *siginfo)
{
int pid = get_ptrace_pid (ptid);
-
- errno = 0;
- ptrace (PTRACE_GETSIGINFO, pid, (PTRACE_TYPE_ARG3) 0, siginfo);
-
- return errno == 0;
+ return ptrace (PTRACE_GETSIGINFO, pid, (PTRACE_TYPE_ARG3) 0, siginfo) == 0;
}
/* See nat/linux-nat.h. */