diff options
author | Tom de Vries <tdevries@suse.de> | 2022-11-26 14:29:10 +0100 |
---|---|---|
committer | Tom de Vries <tdevries@suse.de> | 2022-11-26 14:29:10 +0100 |
commit | 7a0daa48da726f9c05a752e85fefe128bf848916 (patch) | |
tree | 9dd4b85792e6f028fc967f58bc37707ded3ae80a | |
parent | 05ad0d60341f0933501dc90002da3d4594c30438 (diff) | |
download | gdb-7a0daa48da726f9c05a752e85fefe128bf848916.zip gdb-7a0daa48da726f9c05a752e85fefe128bf848916.tar.gz gdb-7a0daa48da726f9c05a752e85fefe128bf848916.tar.bz2 |
[gdb/testsuite] Don't generate core in gdb.base/bt-on-fatal-signal.exp
When running test-case gdb.base/bt-on-fatal-signal.exp on powerpc64le-linux I
noticed:
...
FAIL: gdb.base/bt-on-fatal-signal.exp: SEGV: scan for backtrace (timeout)
...
The timeout is 10 seconds, but generating the core file takes more than a
minute, probably due to slow NFS.
I managed to reproduce this behaviour independently of gdb, by compiling
"int main (void) { __builtin_abort (); }" and running it, which took 1.5
seconds for a core file 50 times smaller than the one for gdb.
Fix this by preventing the core file from being generated, using a wrapper
around gdb that does "ulimit -c 0".
Tested on x86_64-linux.
-rw-r--r-- | gdb/testsuite/gdb.base/bt-on-fatal-signal.exp | 5 | ||||
-rw-r--r-- | gdb/testsuite/lib/gdb.exp | 11 |
2 files changed, 15 insertions, 1 deletions
diff --git a/gdb/testsuite/gdb.base/bt-on-fatal-signal.exp b/gdb/testsuite/gdb.base/bt-on-fatal-signal.exp index 8f9d857..1af88d5 100644 --- a/gdb/testsuite/gdb.base/bt-on-fatal-signal.exp +++ b/gdb/testsuite/gdb.base/bt-on-fatal-signal.exp @@ -62,7 +62,10 @@ foreach test_data {{SEGV "Segmentation fault"} \ with_test_prefix ${sig} { # Restart GDB. - clean_restart $binfile + save_vars { GDB } { + set GDB [gdb_no_core] + clean_restart $binfile + } # Capture the pid of GDB. set testpid [spawn_id_get_pid $gdb_spawn_id] diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 7d05fbe..a73437a 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -6322,6 +6322,17 @@ proc cached_file { filename txt {executable 0}} { return $filename } +# Return a wrapper around gdb that prevents generating a core file. + +proc gdb_no_core { } { + set script \ + [list \ + "ulimit -c 0" \ + [join [list exec $::GDB {"$@"}]]] + set script [join $script "\n"] + return [cached_file gdb-no-core.sh $script 1] +} + # Set 'testfile', 'srcfile', and 'binfile'. # # ARGS is a list of source file specifications. |