diff options
| author | Tom Tromey <tromey@adacore.com> | 2024-04-15 09:33:21 -0600 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2024-04-15 09:37:12 -0600 |
| commit | 5cb1d84e595aac021641622028d0e7f1e8ea8adf (patch) | |
| tree | 070f4b677e6f0aa5eaf1608cada1f880978277a2 | |
| parent | ccbf42ec88f3e8bbb74dbdc1d6c9da3a9d805cff (diff) | |
| download | gdb-5cb1d84e595aac021641622028d0e7f1e8ea8adf.zip gdb-5cb1d84e595aac021641622028d0e7f1e8ea8adf.tar.gz gdb-5cb1d84e595aac021641622028d0e7f1e8ea8adf.tar.bz2 | |
Change printf attribute to fix clang build
commit e8cd90f0 ("Rewrite gdb_bfd_error_handler") broke the clang
build.
The problem here is that print_error_callback isn't marked as being
printf-like, but it calls string_file::vprintf, triggering:
../../binutils-gdb/gdb/gdb_bfd.c:1202:18: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
This patch applies the attribute to this function.
It also removes the attribute from gdb_bfd_error_handler, because that
function is no longer really printf-like.
| -rw-r--r-- | gdb/gdb_bfd.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gdb/gdb_bfd.c b/gdb/gdb_bfd.c index 0120dd0..1462aaf 100644 --- a/gdb/gdb_bfd.c +++ b/gdb/gdb_bfd.c @@ -1192,7 +1192,7 @@ increment_bfd_error_count (const std::string &str) /* A print callback for bfd_print_error. */ -static int +static int ATTRIBUTE_PRINTF (2, 0) print_error_callback (void *stream, const char *fmt, ...) { string_file *file = (string_file *) stream; @@ -1208,7 +1208,7 @@ print_error_callback (void *stream, const char *fmt, ...) messages which have been printed once already. This is done on a per-inferior basis. */ -static void ATTRIBUTE_PRINTF (1, 0) +static void gdb_bfd_error_handler (const char *fmt, va_list ap) { string_file output; |