aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Clifton <nickc@redhat.com>2022-10-19 15:09:12 +0100
committerNick Clifton <nickc@redhat.com>2022-10-19 15:09:12 +0100
commit5c831a3c7f3ca98d6aba1200353311e1a1f84c70 (patch)
tree04a0d715b525443894fc8505ab6efc6bc576dced
parentfeab6abfe23b5b1724cb3c00059254e8f1bc5225 (diff)
downloadgdb-5c831a3c7f3ca98d6aba1200353311e1a1f84c70.zip
gdb-5c831a3c7f3ca98d6aba1200353311e1a1f84c70.tar.gz
gdb-5c831a3c7f3ca98d6aba1200353311e1a1f84c70.tar.bz2
Fix an illegal memory access when parsing an ELF file containing corrupt symbol version information.
PR 29699 * elf.c (_bfd_elf_slurp_version_tables): Fail if the sh_info field of the section header is zero.
-rw-r--r--bfd/ChangeLog6
-rw-r--r--bfd/elf.c4
2 files changed, 9 insertions, 1 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index c618d81..06501775 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2022-10-19 Nick Clifton <nickc@redhat.com>
+
+ PR 29699
+ * elf.c (_bfd_elf_slurp_version_tables): Fail if the sh_info field
+ of the section header is zero.
+
2022-09-09 Nick Clifton <nickc@redhat.com>
PR 29532
diff --git a/bfd/elf.c b/bfd/elf.c
index fe00e0f9..7cd7feb 100644
--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -8918,7 +8918,9 @@ _bfd_elf_slurp_version_tables (bfd *abfd, bool default_imported_symver)
bfd_set_error (bfd_error_file_too_big);
goto error_return_verref;
}
- elf_tdata (abfd)->verref = (Elf_Internal_Verneed *) bfd_alloc (abfd, amt);
+ if (amt == 0)
+ goto error_return_verref;
+ elf_tdata (abfd)->verref = (Elf_Internal_Verneed *) bfd_zalloc (abfd, amt);
if (elf_tdata (abfd)->verref == NULL)
goto error_return_verref;