diff options
| author | Tom de Vries <tdevries@suse.de> | 2024-02-13 10:44:25 +0100 |
|---|---|---|
| committer | Tom de Vries <tdevries@suse.de> | 2024-02-13 10:44:25 +0100 |
| commit | 4dad3c1e1c9e789addc0d196cef8e8ea22ddbeda (patch) | |
| tree | 07c6dbd0f2c5090570dfd5734689edc21eb72959 | |
| parent | 7e4208a3f5d60f43b4a8f02e583fa950b599cd00 (diff) | |
| download | gdb-4dad3c1e1c9e789addc0d196cef8e8ea22ddbeda.zip gdb-4dad3c1e1c9e789addc0d196cef8e8ea22ddbeda.tar.gz gdb-4dad3c1e1c9e789addc0d196cef8e8ea22ddbeda.tar.bz2 | |
[gdb/testsuite] Fix tcl error in gdb.dap/sources.exp
With test-case gdb.dap/sources.exp, I run into:
...
{"request_seq": 4, "type": "response", "command": "source", \
"success": false, "message": "notStopped", \
"seq": 11}FAIL: gdb.dap/sources.exp: get source success
ERROR: tcl error sourcing gdb.dap/sources.exp.
ERROR: key "body" not known in dictionary
...
The FAIL has been filed as PR dap/31374.
The ERROR happens because after the FAIL, dap_check_request_and_response
returns "", and the test-case doesn't check for that.
Fix this by checking for $obj != "" in the test-case.
Tested on x86_64-linux.
| -rw-r--r-- | gdb/testsuite/gdb.dap/sources.exp | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/gdb/testsuite/gdb.dap/sources.exp b/gdb/testsuite/gdb.dap/sources.exp index b606811..f601190 100644 --- a/gdb/testsuite/gdb.dap/sources.exp +++ b/gdb/testsuite/gdb.dap/sources.exp @@ -49,8 +49,10 @@ if {$path == ""} { set obj [dap_check_request_and_response "get source" source \ [format {o source [o path [s %s]] \ sourceReference [i 0]} $path]] - set text [dict get [lindex $obj 0] body content] - gdb_assert {[string first "Distinguishing comment" $text] != -1} + if { $obj != "" } { + set text [dict get [lindex $obj 0] body content] + gdb_assert {[string first "Distinguishing comment" $text] != -1} + } } |