aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon Marchi <simon.marchi@efficios.com>2020-03-12 14:12:36 -0400
committerSimon Marchi <simon.marchi@efficios.com>2020-03-12 14:17:57 -0400
commit4d696a5c686730d75623d7e41805e42ce5fcc60c (patch)
tree077ef2a22bca4befd6b2f9088b80c7b49f703e7f
parent8dd8e1c7228d5dd57b3b36379718c806017988e1 (diff)
downloadgdb-4d696a5c686730d75623d7e41805e42ce5fcc60c.zip
gdb-4d696a5c686730d75623d7e41805e42ce5fcc60c.tar.gz
gdb-4d696a5c686730d75623d7e41805e42ce5fcc60c.tar.bz2
gdb/selftest.m4: ensure $development is set
Before commit 3d1e5a43cbe ("gdbsupport/configure.ac: source development.sh"), the GDB build in non-development mode (turn development to false in bfd/development.sh if you want to try) was broken because the gdbsupport configure script didn't source bfd/development.sh to set the development variable. Since the GDB_AC_SELFTEST macro relies on the `development` variable, I propose to modify it such that it errors out if $development does not have an expected value of "true" or "false". This could prevent a future similar problem from happening while refactoring the configure scripts. It would have caught the problem fixed by the patch mentioned earlier. gdb/ChangeLog: * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is not "true" or "false". * configure: Re-generate. gdbserver/ChangeLog: * configure: Re-generate. gdbsupport/ChangeLog: * configure: Re-generate.
-rw-r--r--gdb/ChangeLog6
-rwxr-xr-xgdb/configure5
-rw-r--r--gdb/selftest.m44
-rw-r--r--gdbserver/ChangeLog4
-rwxr-xr-xgdbserver/configure5
-rw-r--r--gdbsupport/ChangeLog4
-rwxr-xr-xgdbsupport/configure5
7 files changed, 33 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 4ae6fd6..490d9cb 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2020-03-12 Simon Marchi <simon.marchi@efficios.com>
+
+ * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
+ not "true" or "false".
+ * configure: Re-generate.
+
2020-03-12 Christian Biesinger <cbiesinger@google.com>
* Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
diff --git a/gdb/configure b/gdb/configure
index 47ca77f..dd34688 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -19187,6 +19187,11 @@ $as_echo "#define GDB_DEFAULT_HOST_CHARSET \"UTF-8\"" >>confdefs.h
# The default value of this option changes depending whether we're on
# development mode (in which case it's "true") or not (in which case
# it's "false").
+
+if test "x$development" != xtrue && test "x$development" != xfalse; then :
+ as_fn_error $? "Invalid value for \$development, got \"$development\", expecting \"true\" or \"false\"." "$LINENO" 5
+fi
+
# Check whether --enable-unit-tests was given.
if test "${enable_unit_tests+set}" = set; then :
enableval=$enable_unit_tests; case "${enableval}" in
diff --git a/gdb/selftest.m4 b/gdb/selftest.m4
index 4969de1..a88aa96 100644
--- a/gdb/selftest.m4
+++ b/gdb/selftest.m4
@@ -27,6 +27,10 @@ AC_DEFUN([GDB_AC_SELFTEST],[
# The default value of this option changes depending whether we're on
# development mode (in which case it's "true") or not (in which case
# it's "false").
+
+AS_IF([test "x$development" != xtrue && test "x$development" != xfalse],
+ [AC_MSG_ERROR([Invalid value for \$development, got "$development", expecting "true" or "false".])])
+
AC_ARG_ENABLE(unit-tests,
AS_HELP_STRING([--enable-unit-tests],
[Enable the inclusion of unit tests when compiling GDB]),
diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog
index ef8addb..94e1c04 100644
--- a/gdbserver/ChangeLog
+++ b/gdbserver/ChangeLog
@@ -1,3 +1,7 @@
+2020-03-12 Simon Marchi <simon.marchi@efficios.com>
+
+ * configure: Re-generate.
+
2020-03-11 Simon Marchi <simon.marchi@efficios.com>
* configure: Re-generate.
diff --git a/gdbserver/configure b/gdbserver/configure
index 13ac718..b0a2568 100755
--- a/gdbserver/configure
+++ b/gdbserver/configure
@@ -6083,6 +6083,11 @@ fi
# The default value of this option changes depending whether we're on
# development mode (in which case it's "true") or not (in which case
# it's "false").
+
+if test "x$development" != xtrue && test "x$development" != xfalse; then :
+ as_fn_error $? "Invalid value for \$development, got \"$development\", expecting \"true\" or \"false\"." "$LINENO" 5
+fi
+
# Check whether --enable-unit-tests was given.
if test "${enable_unit_tests+set}" = set; then :
enableval=$enable_unit_tests; case "${enableval}" in
diff --git a/gdbsupport/ChangeLog b/gdbsupport/ChangeLog
index f9fe58a..5e4f277 100644
--- a/gdbsupport/ChangeLog
+++ b/gdbsupport/ChangeLog
@@ -1,3 +1,7 @@
+2020-03-12 Simon Marchi <simon.marchi@efficios.com>
+
+ * configure: Re-generate.
+
2020-03-11 Simon Marchi <simon.marchi@efficios.com>
* configure: Re-generate.
diff --git a/gdbsupport/configure b/gdbsupport/configure
index 1b14138..66dc906 100755
--- a/gdbsupport/configure
+++ b/gdbsupport/configure
@@ -10606,6 +10606,11 @@ $as_echo "$bfd_cv_have_sys_procfs_type_elf_fpregset_t" >&6; }
# The default value of this option changes depending whether we're on
# development mode (in which case it's "true") or not (in which case
# it's "false").
+
+if test "x$development" != xtrue && test "x$development" != xfalse; then :
+ as_fn_error $? "Invalid value for \$development, got \"$development\", expecting \"true\" or \"false\"." "$LINENO" 5
+fi
+
# Check whether --enable-unit-tests was given.
if test "${enable_unit_tests+set}" = set; then :
enableval=$enable_unit_tests; case "${enableval}" in