aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Alcock <nick.alcock@oracle.com>2024-07-29 18:02:03 +0100
committerNick Alcock <nick.alcock@oracle.com>2024-07-31 21:10:06 +0100
commit4b04e01284f29a3d0e94fa0e0dd6a11be71c9a65 (patch)
tree1b756d88379fb4fb0e8dbaf84799df312c180496
parent21397b78f9a617c22cfafbf1eebd6fc4b2ecc160 (diff)
downloadgdb-4b04e01284f29a3d0e94fa0e0dd6a11be71c9a65.zip
gdb-4b04e01284f29a3d0e94fa0e0dd6a11be71c9a65.tar.gz
gdb-4b04e01284f29a3d0e94fa0e0dd6a11be71c9a65.tar.bz2
libctf: dump: fix small leak
If you asprintf something and then use it only as input to another asprintf, it helps to free it afterwards. libctf/ * ctf-dump.c (ctf_dump_header): Free the flagstr after use. (ctf_dump): Make a NULL return slightly clearer.
-rw-r--r--libctf/ctf-dump.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/libctf/ctf-dump.c b/libctf/ctf-dump.c
index cd41996..a37d4b7 100644
--- a/libctf/ctf-dump.c
+++ b/libctf/ctf-dump.c
@@ -349,6 +349,7 @@ ctf_dump_header (ctf_dict_t *fp, ctf_dump_state_t *state)
if (asprintf (&str, "Flags: 0x%x (%s)", fp->ctf_openflags, flagstr) < 0)
goto err;
+ free (flagstr);
ctf_dump_append (state, str);
}
@@ -814,7 +815,7 @@ ctf_dump (ctf_dict_t *fp, ctf_dump_state_t **statep, ctf_sect_names_t sect,
if (!str)
{
ctf_set_errno (fp, ENOMEM);
- return str;
+ return NULL;
}
}