diff options
| author | Pedro Alves <palves@redhat.com> | 2019-06-13 00:06:52 +0100 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2019-06-13 00:09:37 +0100 |
| commit | 48c410fb70fe09c036e27092880db687e5c2fb0b (patch) | |
| tree | 443b8726ad4152a7427ee422267ba29bc7f91354 | |
| parent | 93bcb04349eb500781747a542ececc7a8ba3bd95 (diff) | |
| download | gdb-48c410fb70fe09c036e27092880db687e5c2fb0b.zip gdb-48c410fb70fe09c036e27092880db687e5c2fb0b.tar.gz gdb-48c410fb70fe09c036e27092880db687e5c2fb0b.tar.bz2 | |
Fix "set enum-command value junk"
With enum commands, we currently fail to notice junk after the value.
Currently:
(gdb) set print entry-values compact foo
(gdb) show print entry-values foo
Printing of function arguments at function entry is "compact".
After this fix:
(gdb) set print entry-values compact foo
Junk after item "compact": foo
gdb/ChangeLog:
2019-06-13 Pedro Alves <palves@redhat.com>
* cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
after item.
| -rw-r--r-- | gdb/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/cli/cli-setshow.c | 4 |
2 files changed, 9 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 38e34b5..c254e36 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2019-06-13 Pedro Alves <palves@redhat.com> + * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk + after item. + +2019-06-13 Pedro Alves <palves@redhat.com> + * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations. 2019-06-13 Pedro Alves <palves@redhat.com> diff --git a/gdb/cli/cli-setshow.c b/gdb/cli/cli-setshow.c index 96d7bf5..86ebed4 100644 --- a/gdb/cli/cli-setshow.c +++ b/gdb/cli/cli-setshow.c @@ -413,6 +413,10 @@ do_set_command (const char *arg, int from_tty, struct cmd_list_element *c) if (nmatches > 1) error (_("Ambiguous item \"%s\"."), arg); + const char *after = skip_spaces (arg + len); + if (*after != '\0') + error (_("Junk after item \"%.*s\": %s"), len, arg, after); + if (*(const char **) c->var != match) { *(const char **) c->var = match; |