aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSergio Durigan Junior <sergiodj@redhat.com>2019-08-29 16:11:45 -0400
committerSergio Durigan Junior <sergiodj@redhat.com>2019-08-30 17:04:37 -0400
commit47a536d940d2f2bccfec51539b857da06ebc429e (patch)
tree314ff8e2b562fa8208115d340d3119df6d90609e
parentd6a00eba2accffec92a5974c2ad1f79612a6679e (diff)
downloadgdb-47a536d940d2f2bccfec51539b857da06ebc429e.zip
gdb-47a536d940d2f2bccfec51539b857da06ebc429e.tar.gz
gdb-47a536d940d2f2bccfec51539b857da06ebc429e.tar.bz2
Remove "\nError: " suffix from nat/fork-inferior.c:trace_start_error warning message
Rationale: https://sourceware.org/ml/gdb-patches/2019-08/msg00651.html This very simple patch removes the "\nError: " suffix from the warning message printed by nat/fork-inferior.c:trace_start_error. This proved to just pollute the screen, causing things like: Starting program: /usr/bin/true warning: Could not trace the inferior process. Error: warning: ptrace: Permission denied This "Error: " string is not useful at all, and can confuse things, therefore let's just remove it and simplify the resulting messages: Starting program: /usr/bin/true warning: Could not trace the inferior process. warning: ptrace: Permission denied gdb/ChangeLog: 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com> * nat/fork-inferior.c (trace_start_error): Remove "\nError: " suffix from warning message.
-rw-r--r--gdb/ChangeLog5
-rw-r--r--gdb/nat/fork-inferior.c2
2 files changed, 6 insertions, 1 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 2cc7b58..ebcfae1 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
+
+ * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
+ suffix from warning message.
+
2019-08-30 Tom Tromey <tom@tromey.com>
* tui/tui-winsource.h (struct tui_source_window_base)
diff --git a/gdb/nat/fork-inferior.c b/gdb/nat/fork-inferior.c
index 68b51aa..355e9be 100644
--- a/gdb/nat/fork-inferior.c
+++ b/gdb/nat/fork-inferior.c
@@ -580,7 +580,7 @@ trace_start_error (const char *fmt, ...)
va_list ap;
va_start (ap, fmt);
- warning ("Could not trace the inferior process.\nError: ");
+ warning ("Could not trace the inferior process.");
vwarning (fmt, ap);
va_end (ap);