diff options
| author | Andrew Burgess <andrew.burgess@embecosm.com> | 2019-08-22 10:07:00 +0100 |
|---|---|---|
| committer | Andrew Burgess <andrew.burgess@embecosm.com> | 2019-08-22 12:34:42 +0100 |
| commit | 43771869e5021b6bdc02b6eaae103a33c05a821c (patch) | |
| tree | 6837e1d9d469cc7375653d441040393591d2b625 | |
| parent | 652afeef247770b22c44ca292d1f4c65be40a696 (diff) | |
| download | gdb-43771869e5021b6bdc02b6eaae103a33c05a821c.zip gdb-43771869e5021b6bdc02b6eaae103a33c05a821c.tar.gz gdb-43771869e5021b6bdc02b6eaae103a33c05a821c.tar.bz2 | |
gdb/fortran: Remove some dead code from the parser
The Fortran parser contains some code that looks like it was probably
inherited from the C/C++ parser as it checks to see if the current
language is C++, which should never be true when we're in the Fortran
parser.
gdb/ChangeLog:
* f-exp.y (yylex): Remove is_a_field_of_this local variable, and
all uses as this was never set to anything but a zero value.
| -rw-r--r-- | gdb/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/f-exp.y | 14 |
2 files changed, 8 insertions, 11 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 966bfb7..b6d200d 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com> + + * f-exp.y (yylex): Remove is_a_field_of_this local variable, and + all uses as this was never set to anything but a zero value. + 2019-08-21 Bogdan Harjoc <harjoc@gmail.com> * cli/cli-cmds.c (with_command_1): Error out if no arguments. diff --git a/gdb/f-exp.y b/gdb/f-exp.y index 14ea386..9784ad5 100644 --- a/gdb/f-exp.y +++ b/gdb/f-exp.y @@ -1275,7 +1275,6 @@ yylex (void) { std::string tmp = copy_name (yylval.sval); struct block_symbol result; - struct field_of_this_result is_a_field_of_this; enum domain_enum_tag lookup_domains[] = { STRUCT_DOMAIN, @@ -1286,15 +1285,8 @@ yylex (void) for (int i = 0; i < ARRAY_SIZE (lookup_domains); ++i) { - /* Initialize this in case we *don't* use it in this call; that - way we can refer to it unconditionally below. */ - memset (&is_a_field_of_this, 0, sizeof (is_a_field_of_this)); - result = lookup_symbol (tmp.c_str (), pstate->expression_context_block, - lookup_domains[i], - pstate->language ()->la_language - == language_cplus - ? &is_a_field_of_this : NULL); + lookup_domains[i], NULL); if (result.symbol && SYMBOL_CLASS (result.symbol) == LOC_TYPEDEF) { yylval.tsym.type = SYMBOL_TYPE (result.symbol); @@ -1323,14 +1315,14 @@ yylex (void) if (hextype == INT) { yylval.ssym.sym = result; - yylval.ssym.is_a_field_of_this = is_a_field_of_this.type != NULL; + yylval.ssym.is_a_field_of_this = false; return NAME_OR_INT; } } /* Any other kind of symbol */ yylval.ssym.sym = result; - yylval.ssym.is_a_field_of_this = is_a_field_of_this.type != NULL; + yylval.ssym.is_a_field_of_this = false; return NAME; } } |