aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom de Vries <tdevries@suse.de>2021-12-07 09:44:36 +0100
committerTom de Vries <tdevries@suse.de>2021-12-07 09:44:36 +0100
commit4281b0c8fcb19325496094491ce1e046a6401a36 (patch)
tree77dc4320d93ab6aab230cec87b11dcc80368b00e
parentc178f2a133740e64344da6484f71807f236a3c00 (diff)
downloadgdb-4281b0c8fcb19325496094491ce1e046a6401a36.zip
gdb-4281b0c8fcb19325496094491ce1e046a6401a36.tar.gz
gdb-4281b0c8fcb19325496094491ce1e046a6401a36.tar.bz2
[gdb/testsuite] Fix options arg handling in compile_jit_elf_main_as_so
In commit 80ad340c902 ("[gdb/testsuite] use -Ttext-segment for jit-elf tests") the following change was made: ... proc compile_jit_elf_main_as_so {main_solib_srcfile main_solib_binfile options} { - set options [concat $options debug] + global jit_load_address jit_load_increment + + set options [list \ + additional_flags="-DMAIN=jit_dl_main" \ + additional_flags=-DLOAD_ADDRESS=$jit_load_address \ + additional_flags=-DLOAD_INCREMENT=$jit_load_increment \ + debug] ... Before the change, the options argument was used, but after the change not anymore. Fix this by reverting back to using "set options [concat $options ...]". Fixing this gets us twice the -DMAIN=jit_dl_main bit, once from a caller, and once from compile_jit_elf_main_as_so. Fix this by removing the bit from compile_jit_elf_main_as_so, which makes the code similar to compile_jit_main. Tested on x86_64-linux.
-rw-r--r--gdb/testsuite/lib/jit-elf-helpers.exp4
1 files changed, 2 insertions, 2 deletions
diff --git a/gdb/testsuite/lib/jit-elf-helpers.exp b/gdb/testsuite/lib/jit-elf-helpers.exp
index 06f7103..8ff41a3 100644
--- a/gdb/testsuite/lib/jit-elf-helpers.exp
+++ b/gdb/testsuite/lib/jit-elf-helpers.exp
@@ -55,8 +55,8 @@ proc compile_jit_main {main_srcfile main_binfile options} {
proc compile_jit_elf_main_as_so {main_solib_srcfile main_solib_binfile options} {
global jit_load_address jit_load_increment
- set options [list \
- additional_flags="-DMAIN=jit_dl_main" \
+ set options [concat \
+ $options \
additional_flags=-DLOAD_ADDRESS=$jit_load_address \
additional_flags=-DLOAD_INCREMENT=$jit_load_increment \
debug]