diff options
| author | Alan Modra <amodra@gmail.com> | 2024-10-08 09:47:47 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2024-10-08 15:12:14 +1030 |
| commit | 22ad34b314b4597d6fb9a261891726c8d94f2893 (patch) | |
| tree | 1dec9fe9730743f617e1972f8388f78ac411bf16 | |
| parent | 542d8137f9f6a2c66e898af136dc792a3963f932 (diff) | |
| download | gdb-22ad34b314b4597d6fb9a261891726c8d94f2893.zip gdb-22ad34b314b4597d6fb9a261891726c8d94f2893.tar.gz gdb-22ad34b314b4597d6fb9a261891726c8d94f2893.tar.bz2 | |
Revert "objcopy fixes for commit 68bbe1183379"
This reverts commit ef166f451fbc2c7b251a251ab23cd35b36c5ee23.
| -rw-r--r-- | binutils/objcopy.c | 16 |
1 files changed, 5 insertions, 11 deletions
diff --git a/binutils/objcopy.c b/binutils/objcopy.c index 2ed1afb..24e31cc 100644 --- a/binutils/objcopy.c +++ b/binutils/objcopy.c @@ -1251,9 +1251,6 @@ is_specified_symbol_predicate (void **slot, void *data) static bool is_specified_symbol (const char *name, htab_t htab) { - if (name == NULL) - return false; - if (wildcard) { struct is_specified_symbol_predicate_data data; @@ -1579,9 +1576,6 @@ filter_symbols (bfd *abfd, bfd *obfd, asymbol **osyms, bool rem_leading_char; bool add_leading_char; - if (name == NULL) - continue; - undefined = bfd_is_und_section (bfd_asymbol_section (sym)); if (add_sym_list) @@ -1596,14 +1590,14 @@ filter_symbols (bfd *abfd, bfd *obfd, asymbol **osyms, { char *new_name; - if (name[0] == '_' + if (name != NULL + && name[0] == '_' && name[1] == '_' && strcmp (name + (name[2] == '_'), "__gnu_lto_slim") == 0) { - fatal (_("redefining symbols does not work" - " on LTO-compiled object files")); + fatal (_("redefining symbols does not work on LTO-compiled object files")); } - + new_name = (char *) lookup_sym_redefinition (name); if (new_name == name && (flags & BSF_SECTION_SYM) != 0) @@ -2962,7 +2956,7 @@ copy_object (bfd *ibfd, bfd *obfd, const bfd_arch_info_type *input_arch) pset = find_section_list (padd->name, false, SECTION_CONTEXT_SET_FLAGS); if (pset != NULL) - { + { flags = pset->flags | SEC_HAS_CONTENTS; flags = check_new_section_flags (flags, obfd, padd->name); } |