aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPierre Muller <muller@sourceware.org>2011-04-19 12:57:37 +0000
committerPierre Muller <muller@sourceware.org>2011-04-19 12:57:37 +0000
commit1c6e1b0de23f49e732b0ce5ed4373b43ebeb401f (patch)
tree19478e9269a659b56e135a067261de90163aa0d6
parent74de023457c7e18e1835f64a5edf7b405e80a095 (diff)
downloadgdb-1c6e1b0de23f49e732b0ce5ed4373b43ebeb401f.zip
gdb-1c6e1b0de23f49e732b0ce5ed4373b43ebeb401f.tar.gz
gdb-1c6e1b0de23f49e732b0ce5ed4373b43ebeb401f.tar.bz2
* xstormy16-tdep.c (xstormy16_push_dummy_call): Add local
variables to simplify code and avoid == operator at end of line as this is against GNU coding standards.
-rw-r--r--gdb/ChangeLog7
-rw-r--r--gdb/xstormy16-tdep.c13
2 files changed, 14 insertions, 6 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index b758a71..c4a98be 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,4 +1,11 @@
2011-04-19 Pierre Muller <muller@ics.u-strasbg.fr>
+ Pedro Alves <pedro@codesourcery.com>
+
+ * xstormy16-tdep.c (xstormy16_push_dummy_call): Add local
+ variables to simplify code and avoid == operator at end of
+ line as this is against GNU coding standards.
+
+2011-04-19 Pierre Muller <muller@ics.u-strasbg.fr>
* solib-svr4.c (svr4_keep_data_in_core): Rename local variable
lm_name to name_lm to avoid conflict with lm_name function.
diff --git a/gdb/xstormy16-tdep.c b/gdb/xstormy16-tdep.c
index 53cbecd..bf32cbd 100644
--- a/gdb/xstormy16-tdep.c
+++ b/gdb/xstormy16-tdep.c
@@ -263,12 +263,13 @@ xstormy16_push_dummy_call (struct gdbarch *gdbarch,
/* Put argument into registers wordwise. */
val = value_contents (args[i]);
for (j = 0; j < typelen; j += xstormy16_reg_size)
- regcache_cooked_write_unsigned (regcache, argreg++,
- extract_unsigned_integer (val + j,
- typelen - j ==
- 1 ? 1 :
- xstormy16_reg_size,
- byte_order));
+ {
+ ULONGEST regval;
+ int size = (typelen - j == 1) ? 1 : xstormy16_reg_size;
+
+ regval = extract_unsigned_integer (val + j, size, byte_order);
+ regcache_cooked_write_unsigned (regcache, argreg++, regval);
+ }
}
/* Align SP */