aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Cagney <cagney@redhat.com>1998-12-03 05:34:25 +0000
committerAndrew Cagney <cagney@redhat.com>1998-12-03 05:34:25 +0000
commit1c3cd1b020893108b0b94fc2b0990200240887d8 (patch)
tree2405ec14bff6a53ae5fb94e88d7405497eab2f3e
parent321d48c5b8248865d580c9e169ceb776730b7644 (diff)
downloadgdb-1c3cd1b020893108b0b94fc2b0990200240887d8.zip
gdb-1c3cd1b020893108b0b94fc2b0990200240887d8.tar.gz
gdb-1c3cd1b020893108b0b94fc2b0990200240887d8.tar.bz2
Clean up function return types. Functions not returning values,
functions unnecessarily returning values.
-rw-r--r--gdb/ChangeLog21
-rw-r--r--gdb/i960-tdep.c1
-rw-r--r--gdb/jv-valprint.c1
-rw-r--r--gdb/monitor.c24
-rw-r--r--gdb/monitor.h1
-rw-r--r--gdb/remote-array.c5
-rw-r--r--gdb/remote-rdi.c2
-rw-r--r--gdb/remote-sds.c3
-rw-r--r--gdb/w89k-rom.c3
-rw-r--r--gdb/z8k-tdep.c2
10 files changed, 44 insertions, 19 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 25b466d..ee80595 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,24 @@
+Thu Dec 3 16:30:35 1998 Andrew Cagney <cagney@b1.cygnus.com>
+
+ * ax-gdb.c: Include target.h.
+
+Tue Dec 3 10:59:00 1998 Andrew Cagney <cagney@b1.cygnus.com>
+
+ * ax-gdb.c (_initialize_ax_gdb), i960-tdep.c (pop_frame),
+ monitor.c (flush_monitor_dcache, longlongendswap), remote-array.c
+ (hexword2ascii), w89k-rom.c (init_w89k_cmds), z8k-tdep.c
+ (init_frame_pc, extract_return_value): Make return type void.
+ * monitor.c (monitor_write_even_block): Make return type explicit.
+ (monotor_read_memory_block): Delete function.
+ * monitor.h: Update.
+ * remote.c (remote_get_threadlist, remote_update_threads),
+ remote-array.c (array_get_packet), remote-rdi.c (Fail): Always
+ return a value.
+ * m32r-tdep.c (m32r_fix_call_dummy): From Michael Snyder, void
+ function.
+ * jv-valprint.c (java_val_print): From Stu Grossman. Return 0 by
+ default.
+
Wed Dec 2 15:11:38 1998 Michael Snyder <msnyder@cleaver.cygnus.com>
* tracepoint.c: Move default definition of
diff --git a/gdb/i960-tdep.c b/gdb/i960-tdep.c
index f87d6bb..0452b95 100644
--- a/gdb/i960-tdep.c
+++ b/gdb/i960-tdep.c
@@ -544,6 +544,7 @@ saved_pc_after_call (frame)
/* Discard from the stack the innermost frame,
restoring all saved registers. */
+void
pop_frame ()
{
register struct frame_info *current_fi, *prev_fi;
diff --git a/gdb/jv-valprint.c b/gdb/jv-valprint.c
index 3833984..0f3d639b 100644
--- a/gdb/jv-valprint.c
+++ b/gdb/jv-valprint.c
@@ -479,4 +479,5 @@ java_val_print (type, valaddr, address, stream, format, deref_ref, recurse,
return c_val_print (type, valaddr, address, stream, format,
deref_ref, recurse, pretty);
}
+ return 0;
}
diff --git a/gdb/monitor.c b/gdb/monitor.c
index 3e0a488..60cfc14 100644
--- a/gdb/monitor.c
+++ b/gdb/monitor.c
@@ -419,7 +419,7 @@ readchar (timeout)
if (c == SERIAL_TIMEOUT)
#if 0 /* MAINTENANCE_CMDS */
- /* I fail to see how detaching here can be useful
+ /* I fail to see how detaching here can be useful */
if (in_monitor_wait) /* Watchdog went off */
{
target_mourn_inferior ();
@@ -794,7 +794,11 @@ monitor_supply_register (regno, valstr)
/* Tell the remote machine to resume. */
-int flush_monitor_dcache(void) { dcache_flush (remote_dcache); }
+void
+flush_monitor_dcache ()
+{
+ dcache_flush (remote_dcache);
+}
static void
monitor_resume (pid, step, sig)
@@ -1360,7 +1364,8 @@ monitor_write_memory (memaddr, myaddr, len)
}
-static monitor_write_even_block(memaddr,myaddr,len)
+static int
+monitor_write_even_block(memaddr,myaddr,len)
CORE_ADDR memaddr ;
char * myaddr ;
int len ;
@@ -1418,7 +1423,8 @@ static int monitor_write_memory_bytes(memaddr,myaddr,len)
}
-static longlongendswap(unsigned char * a)
+static void
+longlongendswap (unsigned char * a)
{
int i,j ;
unsigned char x ;
@@ -1831,16 +1837,6 @@ monitor_read_memory (memaddr, myaddr, len)
return len;
}
-/* This version supports very large reads by looping on multiline
- dump bytes outputs. Beware of buffering limits.
- */
-static int monotor_read_memory_block(memaddr,myaddr,len)
- CORE_ADDR memaddr ;
- char * myaddr ;
- int len ;
-{
-}
-
static int
monitor_xfer_memory (memaddr, myaddr, len, write, target)
CORE_ADDR memaddr;
diff --git a/gdb/monitor.h b/gdb/monitor.h
index 6864165..4ccddd5 100644
--- a/gdb/monitor.h
+++ b/gdb/monitor.h
@@ -244,3 +244,4 @@ extern int monitor_readchar PARAMS ((void));
extern char *monitor_get_dev_name PARAMS ((void));
extern void init_monitor_ops PARAMS ((struct target_ops *));
extern int monitor_dump_reg_block PARAMS((char * dump_cmd)) ;
+extern void flush_monitor_dcache PARAMS ((void));
diff --git a/gdb/remote-array.c b/gdb/remote-array.c
index 795a645..b250cc4 100644
--- a/gdb/remote-array.c
+++ b/gdb/remote-array.c
@@ -90,7 +90,7 @@ static int from_hex();
static int array_send_packet();
static int array_get_packet();
static unsigned long ascii2hexword();
-static char *hexword2ascii();
+static void hexword2ascii();
extern char *version;
@@ -1365,6 +1365,7 @@ array_get_packet (packet)
}
}
}
+ return 0; /* exceeded retries */
}
/*
@@ -1398,7 +1399,7 @@ ascii2hexword (mem)
* ascii2hexword -- convert a hex value to an ascii number represented by 8
* digits.
*/
-static char*
+static void
hexword2ascii (mem, num)
unsigned char *mem;
unsigned long num;
diff --git a/gdb/remote-rdi.c b/gdb/remote-rdi.c
index f4d87ad..3cd3ea1 100644
--- a/gdb/remote-rdi.c
+++ b/gdb/remote-rdi.c
@@ -970,4 +970,4 @@ _initialize_remote_rdi ()
/* A little dummy to make linking with the library succeed. */
-Fail() {}
+int Fail() { return 0; }
diff --git a/gdb/remote-sds.c b/gdb/remote-sds.c
index 312d26a..d3c6b70 100644
--- a/gdb/remote-sds.c
+++ b/gdb/remote-sds.c
@@ -976,7 +976,7 @@ getmessage (buf, forever)
if (c3 == '+')
{
message_pending = 1;
- return;
+ return 0; /*????*/
}
continue;
}
@@ -1028,6 +1028,7 @@ getmessage (buf, forever)
/* We have tried hard enough, and just can't receive the packet. Give up. */
printf_unfiltered ("Ignoring packet error, continuing...\n");
+ return 0;
}
static void
diff --git a/gdb/w89k-rom.c b/gdb/w89k-rom.c
index e6e63c4..d01a265 100644
--- a/gdb/w89k-rom.c
+++ b/gdb/w89k-rom.c
@@ -244,7 +244,8 @@ static struct target_ops w89k_ops;
static char *w89k_inits[] = {"\n", NULL};
static struct monitor_ops w89k_cmds ;
-static init_w89k_cmds(void)
+static void
+init_w89k_cmds(void)
{
w89k_cmds.flags = MO_GETMEM_NEEDS_RANGE|MO_FILL_USES_ADDR; /* flags */
w89k_cmds.init = w89k_inits; /* Init strings */
diff --git a/gdb/z8k-tdep.c b/gdb/z8k-tdep.c
index 29e9f6b..2afacf2 100644
--- a/gdb/z8k-tdep.c
+++ b/gdb/z8k-tdep.c
@@ -172,6 +172,7 @@ frame_chain (thisframe)
return 0;
}
+void
init_frame_pc ()
{
abort ();
@@ -299,6 +300,7 @@ saved_pc_after_call ()
}
+void
extract_return_value (type, regbuf, valbuf)
struct type *type;
char *regbuf;