diff options
| author | Tom Tromey <tom@tromey.com> | 2018-05-10 08:38:51 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2018-05-10 10:05:35 -0600 |
| commit | 1a34f210bb9389e58d93caf4384800934fc7113a (patch) | |
| tree | 24f8480bd7081b458ee143bfaa6ea994523b05f0 | |
| parent | 6688183925d82d4049931e95bc4e963ab66e770d (diff) | |
| download | gdb-1a34f210bb9389e58d93caf4384800934fc7113a.zip gdb-1a34f210bb9389e58d93caf4384800934fc7113a.tar.gz gdb-1a34f210bb9389e58d93caf4384800934fc7113a.tar.bz2 | |
Fix the clang build
Simon pointed out that gdb would not build with clang, due to the
addition of -Wimplicit-fallthrough. This patch fixes the problem by
using -Wimplicit-fallthrough=3 -- this does not work with clang,
bypassing the issue.
Tested by rebuilding with both gcc and clang; and also by verifying
that -Wimplicit-fallthrough=3 is used in the gcc build.
I will file a follow-up bug to convert the fall-through comments to a
form that can be used by both clang and gcc.
gdb/ChangeLog
2018-05-10 Tom Tromey <tom@tromey.com>
* configure: Rebuild.
* warning.m4 (AM_GDB_WARNINGS): Use -Wimplicit-fallthrough=3.
gdb/gdbserver/ChangeLog
2018-05-10 Tom Tromey <tom@tromey.com>
* configure: Rebuild.
| -rw-r--r-- | gdb/ChangeLog | 5 | ||||
| -rwxr-xr-x | gdb/configure | 2 | ||||
| -rw-r--r-- | gdb/gdbserver/ChangeLog | 4 | ||||
| -rwxr-xr-x | gdb/gdbserver/configure | 2 | ||||
| -rw-r--r-- | gdb/warning.m4 | 2 |
5 files changed, 12 insertions, 3 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 3467467..f5ae525 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2018-05-10 Tom Tromey <tom@tromey.com> + + * configure: Rebuild. + * warning.m4 (AM_GDB_WARNINGS): Use -Wimplicit-fallthrough=3. + 2018-05-10 Joel Brobecker <brobecker@adacore.com> PR server/23158: diff --git a/gdb/configure b/gdb/configure index 0eec780..4186f7e 100755 --- a/gdb/configure +++ b/gdb/configure @@ -15367,7 +15367,7 @@ build_warnings="-Wall -Wpointer-arith \ -Wno-mismatched-tags \ -Wno-error=deprecated-register \ -Wsuggest-override \ --Wimplicit-fallthrough \ +-Wimplicit-fallthrough=3 \ -Wduplicated-cond" case "${host}" in diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index 9ead122..36915cf 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,7 @@ +2018-05-10 Tom Tromey <tom@tromey.com> + + * configure: Rebuild. + 2018-05-10 Joel Brobecker <brobecker@adacore.com> PR server/23158: diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure index ac61ba3..b2e2e8f 100755 --- a/gdb/gdbserver/configure +++ b/gdb/gdbserver/configure @@ -7174,7 +7174,7 @@ build_warnings="-Wall -Wpointer-arith \ -Wno-mismatched-tags \ -Wno-error=deprecated-register \ -Wsuggest-override \ --Wimplicit-fallthrough \ +-Wimplicit-fallthrough=3 \ -Wduplicated-cond" case "${host}" in diff --git a/gdb/warning.m4 b/gdb/warning.m4 index cb23472..632cc21 100644 --- a/gdb/warning.m4 +++ b/gdb/warning.m4 @@ -44,7 +44,7 @@ build_warnings="-Wall -Wpointer-arith \ -Wno-mismatched-tags \ -Wno-error=deprecated-register \ -Wsuggest-override \ --Wimplicit-fallthrough \ +-Wimplicit-fallthrough=3 \ -Wduplicated-cond" case "${host}" in |