diff options
| author | Tom de Vries <tdevries@suse.de> | 2024-04-17 11:45:02 +0200 |
|---|---|---|
| committer | Tom de Vries <tdevries@suse.de> | 2024-04-17 11:45:02 +0200 |
| commit | 0f077fcae0f1b090439169c471bba29b3be86615 (patch) | |
| tree | 48f20188b6b546118ff42c9eb6ca4f5008238095 | |
| parent | e59144c6edc425653836e1f9fb138799ee419889 (diff) | |
| download | gdb-0f077fcae0f1b090439169c471bba29b3be86615.zip gdb-0f077fcae0f1b090439169c471bba29b3be86615.tar.gz gdb-0f077fcae0f1b090439169c471bba29b3be86615.tar.bz2 | |
[gdb/testsuite] Simplify gdb.server/server-kill-python.exp
In test-case gdb.server/server-kill-python.exp we have:
...
if {[gdb_spawn_with_cmdline_opts \
"-quiet -iex \"set height 0\" -iex \"set width 0\" -ex \"source $host_file1\""] != 0} {
fail "spawn"
return
}
...
I reproduced the problem by reverting the fix at the commit adding both the
fix and the test-case, and the reproduced the same problem using:
...
(gdb) source $host_file1
...
so there doesn't seem to be a specific need to source the python file using
"-ex".
Simplify the test-case by sourcing the python file using send_gdb.
This also allow us to simplify the python script.
Tested on x86_64-linux.
| -rw-r--r-- | gdb/testsuite/gdb.server/server-kill-python.exp | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/gdb/testsuite/gdb.server/server-kill-python.exp b/gdb/testsuite/gdb.server/server-kill-python.exp index ebf6176..87f9b56 100644 --- a/gdb/testsuite/gdb.server/server-kill-python.exp +++ b/gdb/testsuite/gdb.server/server-kill-python.exp @@ -48,8 +48,6 @@ puts $fd \ "import gdb def do_gdb_stuff (): - gdb.execute ('file $host_binfile') - gdb.execute ('target $gdbserver_protocol $gdbserver_gdbport') gdb.execute ('break $srcfile:$break_linenr') gdb.execute ('continue') gdb.execute ('p server_pid') @@ -63,11 +61,15 @@ set host_file1 [gdb_remote_download host $file1] # Now start GDB, sourcing the python command file we generated above. # Set the height and width so we don't end up at a paging prompt. if {[gdb_spawn_with_cmdline_opts \ - "-quiet -iex \"set height 0\" -iex \"set width 0\" -ex \"source $host_file1\""] != 0} { + "-quiet -iex \"set height 0\" -iex \"set width 0\""] != 0} { fail "spawn" return } +gdb_load $binfile +gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport +send_gdb "source $host_file1\n" + # Get the gdbserver PID. set gdbserver_pid 0 |