diff options
| author | Jan Kratochvil <jan.kratochvil@redhat.com> | 2016-03-24 22:42:09 +0100 |
|---|---|---|
| committer | Jan Kratochvil <jan.kratochvil@redhat.com> | 2016-03-24 22:42:09 +0100 |
| commit | 0d2f91fe2d5ea93dc3dc76780e6ec2e27d022d39 (patch) | |
| tree | 50438dc3eb17b75889544974c8ed09842010256e | |
| parent | f65c3d1b26e05f445d976aabd48d4b1264c182bc (diff) | |
| download | gdb-0d2f91fe2d5ea93dc3dc76780e6ec2e27d022d39.zip gdb-0d2f91fe2d5ea93dc3dc76780e6ec2e27d022d39.tar.gz gdb-0d2f91fe2d5ea93dc3dc76780e6ec2e27d022d39.tar.bz2 | |
More -Wstack-usage warnings: opcodes/aarch64-*
opcodes Fix -Wstack-usage warnings.
* aarch64-dis.c (print_operands): Substitute size.
* aarch64-opc.c (print_register_offset_address): Substitute tblen.
| -rw-r--r-- | opcodes/ChangeLog | 6 | ||||
| -rw-r--r-- | opcodes/aarch64-dis.c | 5 | ||||
| -rw-r--r-- | opcodes/aarch64-opc.c | 7 |
3 files changed, 11 insertions, 7 deletions
diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog index 3678971..3fc87d6 100644 --- a/opcodes/ChangeLog +++ b/opcodes/ChangeLog @@ -1,3 +1,9 @@ +2016-03-24 Jan Kratochvil <jan.kratochvil@redhat.com> + + Fix -Wstack-usage warnings. + * aarch64-dis.c (print_operands): Substitute size. + * aarch64-opc.c (print_register_offset_address): Substitute tblen. + 2016-03-22 Jose E. Marchesi <jose.marchesi@oracle.com> * sparc-opc.c (sparc_opcodes): Reorder entries for `rd' in order diff --git a/opcodes/aarch64-dis.c b/opcodes/aarch64-dis.c index 025d5d1..05e4768 100644 --- a/opcodes/aarch64-dis.c +++ b/opcodes/aarch64-dis.c @@ -2154,8 +2154,7 @@ print_operands (bfd_vma pc, const aarch64_opcode *opcode, int i, pcrel_p, num_printed; for (i = 0, num_printed = 0; i < AARCH64_MAX_OPND_NUM; ++i) { - const size_t size = 128; - char str[size]; + char str[128]; /* We regard the opcode operand info more, however we also look into the inst->operands to support the disassembling of the optional operand. @@ -2166,7 +2165,7 @@ print_operands (bfd_vma pc, const aarch64_opcode *opcode, break; /* Generate the operand string in STR. */ - aarch64_print_operand (str, size, pc, opcode, opnds, i, &pcrel_p, + aarch64_print_operand (str, sizeof (str), pc, opcode, opnds, i, &pcrel_p, &info->target); /* Print the delimiter (taking account of omitted operand(s)). */ diff --git a/opcodes/aarch64-opc.c b/opcodes/aarch64-opc.c index ae06ee3..76992df 100644 --- a/opcodes/aarch64-opc.c +++ b/opcodes/aarch64-opc.c @@ -2301,8 +2301,7 @@ static void print_register_offset_address (char *buf, size_t size, const aarch64_opnd_info *opnd) { - const size_t tblen = 16; - char tb[tblen]; /* Temporary buffer. */ + char tb[16]; /* Temporary buffer. */ bfd_boolean lsl_p = FALSE; /* Is LSL shift operator? */ bfd_boolean wm_p = FALSE; /* Should Rm be Wm? */ bfd_boolean print_extend_p = TRUE; @@ -2334,9 +2333,9 @@ print_register_offset_address (char *buf, size_t size, if (print_extend_p) { if (print_amount_p) - snprintf (tb, tblen, ",%s #%d", shift_name, opnd->shifter.amount); + snprintf (tb, sizeof (tb), ",%s #%d", shift_name, opnd->shifter.amount); else - snprintf (tb, tblen, ",%s", shift_name); + snprintf (tb, sizeof (tb), ",%s", shift_name); } else tb[0] = '\0'; |