aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom de Vries <tdevries@suse.de>2023-07-22 11:00:25 +0200
committerTom de Vries <tdevries@suse.de>2023-07-22 11:00:25 +0200
commit09075d5d4a2b6dbbc3ca20e2b963799b4c5d638d (patch)
tree26a643e15fa799633626c51e1b1812edd6442871
parent6fbe38ce1170415bc1d2fe596911a056091949de (diff)
downloadgdb-09075d5d4a2b6dbbc3ca20e2b963799b4c5d638d.zip
gdb-09075d5d4a2b6dbbc3ca20e2b963799b4c5d638d.tar.gz
gdb-09075d5d4a2b6dbbc3ca20e2b963799b4c5d638d.tar.bz2
[gdb/testsuite] Use proc readnow in two test-cases
Use "require !readnow" in two test-cases, instead of the written-out variant. Tested on x86_64-linux, with target boards unix and readnow.
-rw-r--r--gdb/testsuite/gdb.arch/arm-pthread_cond_timedwait-bt.exp11
-rw-r--r--gdb/testsuite/gdb.base/readnever.exp11
2 files changed, 8 insertions, 14 deletions
diff --git a/gdb/testsuite/gdb.arch/arm-pthread_cond_timedwait-bt.exp b/gdb/testsuite/gdb.arch/arm-pthread_cond_timedwait-bt.exp
index 0cf7f27..17f8d68 100644
--- a/gdb/testsuite/gdb.arch/arm-pthread_cond_timedwait-bt.exp
+++ b/gdb/testsuite/gdb.arch/arm-pthread_cond_timedwait-bt.exp
@@ -17,6 +17,10 @@
# syscall is active. But some active syscalls keep PC pointing to the SVC
# instruction itself.
+# See if we have target board readnow.exp or similar. We're using
+# --readnever, which is not allowed in combination with --readnow.
+require !readnow
+
standard_testfile
if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \
@@ -24,13 +28,6 @@ if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \
return
}
-# See if we have target board readnow.exp or similar.
-if { [lsearch -exact $GDBFLAGS -readnow] != -1 \
- || [lsearch -exact $GDBFLAGS --readnow] != -1 } {
- untested "--readnever not allowed in combination with --readnow"
- return -1
-}
-
save_vars { GDBFLAGS } {
append GDBFLAGS " --readnever"
if { [clean_restart ${binfile}] == -1 } {
diff --git a/gdb/testsuite/gdb.base/readnever.exp b/gdb/testsuite/gdb.base/readnever.exp
index 765b5bd..8a21c41 100644
--- a/gdb/testsuite/gdb.base/readnever.exp
+++ b/gdb/testsuite/gdb.base/readnever.exp
@@ -13,6 +13,10 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
+# See if we have target board readnow.exp or similar. We're using
+# --readnever, which is not allowed in combination with --readnow.
+require !readnow
+
standard_testfile .c
if { [build_executable "failed to build" $testfile $srcfile { debug }] == -1 } {
@@ -20,13 +24,6 @@ if { [build_executable "failed to build" $testfile $srcfile { debug }] == -1 } {
return -1
}
-# See if we have target board readnow.exp or similar.
-if { [lsearch -exact $GDBFLAGS -readnow] != -1 \
- || [lsearch -exact $GDBFLAGS --readnow] != -1 } {
- untested "--readnever not allowed in combination with --readnow"
- return -1
-}
-
save_vars { GDBFLAGS } {
append GDBFLAGS " --readnever"
if { [clean_restart ${binfile}] == -1 } {