diff options
| author | Alan Modra <amodra@gmail.com> | 2016-07-15 17:02:00 +0930 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2016-07-15 17:02:00 +0930 |
| commit | 06ab6faf83ce47ca64198819eee02e4e56dc5a74 (patch) | |
| tree | b892a47dbe32cc573577edf478a15e0561b499d1 | |
| parent | 50c1cbe1895eaa6cdc7163851799f6f5d8f9336f (diff) | |
| download | gdb-06ab6faf83ce47ca64198819eee02e4e56dc5a74.zip gdb-06ab6faf83ce47ca64198819eee02e4e56dc5a74.tar.gz gdb-06ab6faf83ce47ca64198819eee02e4e56dc5a74.tar.bz2 | |
COFF buffer overflow in mark_relocs
* cofflink.c (mark_relocs): Exclude relocs with -1 r_symndx
from marking sym_indices.
| -rw-r--r-- | bfd/ChangeLog | 5 | ||||
| -rw-r--r-- | bfd/cofflink.c | 3 |
2 files changed, 7 insertions, 1 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index a889e56..0fa96f2 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,8 @@ +2016-07-15 Alan Modra <amodra@gmail.com> + + * cofflink.c (mark_relocs): Exclude relocs with -1 r_symndx + from marking sym_indices. + 2016-07-14 Maciej W. Rozycki <macro@imgtec.com> * reloc.c (bfd_perform_relocation): Try the `howto' handler diff --git a/bfd/cofflink.c b/bfd/cofflink.c index bcdf778..0f6ef59 100644 --- a/bfd/cofflink.c +++ b/bfd/cofflink.c @@ -1398,7 +1398,8 @@ mark_relocs (struct coff_final_link_info *flaginfo, bfd *input_bfd) in the relocation table. This will then be picked up in the skip/don't-skip pass. */ for (; irel < irelend; irel++) - flaginfo->sym_indices[ irel->r_symndx ] = -1; + if ((unsigned long) irel->r_symndx < obj_raw_syment_count (input_bfd)) + flaginfo->sym_indices[irel->r_symndx] = -1; } } |