1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
|
/* { dg-additional-options "-Wno-analyzer-null-argument" } */
/* { dg-require-effective-target alloca } */
#include <stdio.h>
#include <stdlib.h>
extern void populate (char *buf);
void test_passthrough (char *s)
{
putenv (s);
}
void test_str_lit (void)
{
putenv ("NAME=value");
}
/* glibc allows strings without an equal sign. */
void test_no_eq (void)
{
putenv ("NAME");
}
void test_empty_string (void)
{
putenv ("");
}
void test_NULL (void)
{
putenv (NULL); /* possibly -Wanalyzer-null-argument */
}
void test_auto_buf_name_and_value (const char *name, const char *value)
{
char buf[100]; /* { dg-message "'buf' declared on stack here" } */
snprintf (buf, sizeof (buf), "%s=%s", name, value);
putenv (buf); /* { dg-warning "'putenv' on a pointer to automatic variable 'buf' \\\[POS34-C\\\]" "warning" } */
/* { dg-message "perhaps use 'setenv' rather than 'putenv'" "setenv suggestion" { target *-*-* } .-1 } */
}
void test_auto_buf_value (const char *value)
{
char buf[100]; /* { dg-message "'buf' declared on stack here" } */
snprintf (buf, sizeof (buf), "NAME=%s", value);
putenv (buf); /* { dg-warning "'putenv' on a pointer to automatic variable 'buf' \\\[POS34-C\\\]" } */
}
void test_static_buf (const char *value)
{
static char buf[100];
snprintf (buf, sizeof (buf), "NAME=%s", value);
putenv (buf);
}
static char global_buf[1024];
void test_global (const char *value)
{
snprintf (global_buf, sizeof (global_buf), "NAME=%s", value);
putenv (global_buf);
}
void test_alloca (void)
{
char *buf = __builtin_alloca (256); /* { dg-message "region created on stack here" } */
populate (buf);
putenv (buf); /* { dg-warning "'putenv' on a pointer to an on-stack buffer \\\[POS34-C\\\]" } */
}
void test_malloc_1 (void)
{
char *buf = malloc (1024);
if (!buf)
return;
populate (buf);
putenv (buf);
}
void test_malloc_2 (void)
{
const char *kvstr = "NAME=value";
size_t len = __builtin_strlen (kvstr);
char *buf = __builtin_malloc (len + 1);
if (!buf)
return;
__builtin_memcpy (buf, kvstr, len);
buf[len] = '\0';
putenv (buf); /* { dg-bogus "leak" } */
}
void test_arr (void)
{
char arr[] = "NAME=VALUE"; /* { dg-message "'arr' declared on stack here" } */
putenv (arr); /* { dg-warning "'putenv' on a pointer to automatic variable 'arr' \\\[POS34-C\\\]" } */
}
static void __attribute__((noinline))
__analyzer_test_inner (char *kvstr)
{
putenv (kvstr); /* { dg-warning "'putenv' on a pointer to automatic variable 'arr_outer' \\\[POS34-C\\\]" } */
}
void test_outer (void)
{
char arr_outer[] = "NAME=VALUE"; /* { dg-message "'arr_outer' declared on stack here" } */
__analyzer_test_inner (arr_outer);
}
void test_unterminated (void)
{
char buf[3] = "abc";
putenv (buf); /* { dg-warning "passing pointer to unterminated string" } */
/* { dg-warning "'putenv' on a pointer to automatic variable 'buf'" "POS34-C" { target *-*-* } .-1 } */
}
|
