aboutsummaryrefslogtreecommitdiff
path: root/gcc/rust/expand/rust-macro-builtins-asm.cc
blob: 5ed24d641cef3c1922d6838a313eb6d7069df1ff (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
// Copyright (C) 2020-2025 Free Software Foundation, Inc.

// This file is part of GCC.

// GCC is free software; you can redistribute it and/or modify it under
// the terms of the GNU General Public License as published by the Free
// Software Foundation; either version 3, or (at your option) any later
// version.

// GCC is distributed in the hope that it will be useful, but WITHOUT ANY
// WARRANTY; without even the implied warranty of MERCHANTABILITY or
// FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
// for more details.

// You should have received a copy of the GNU General Public License
// along with GCC; see the file COPYING3.  If not see
// <http://www.gnu.org/licenses/>.

#include "expected.h"
#include "rust-make-unique.h"
#include "rust-macro-builtins-asm.h"
#include "rust-ast-fragment.h"
#include "rust-ast.h"
#include "rust-fmt.h"
#include "rust-stmt.h"

namespace Rust {
std::map<AST::InlineAsmOption, std::string> InlineAsmOptionMap{
  {AST::InlineAsmOption::PURE, "pure"},
  {AST::InlineAsmOption::NOMEM, "nomem"},
  {AST::InlineAsmOption::READONLY, "readonly"},
  {AST::InlineAsmOption::PRESERVES_FLAGS, "preserves_flags"},
  {AST::InlineAsmOption::NORETURN, "noreturn"},
  {AST::InlineAsmOption::NOSTACK, "nostack"},
  {AST::InlineAsmOption::MAY_UNWIND, "may_unwind"},
  {AST::InlineAsmOption::ATT_SYNTAX, "att_syntax"},
  {AST::InlineAsmOption::RAW, "raw"},
};

std::set<std::string> potentially_nonpromoted_keywords
  = {"in", "out", "lateout", "inout", "inlateout", "const", "sym", "label"};

std::string
strip_double_quotes (const std::string &str)
{
  // Helper function strips the beginning and ending double quotes from a
  // string.
  std::string result = str;

  rust_assert (result.size () >= 3);
  result.erase (0, 1);
  result.erase (result.size () - 1, 1);
  return result;
}

tl::expected<InlineAsmContext, InlineAsmParseError>
parse_clobber_abi (InlineAsmContext inline_asm_ctx)
{
  // clobber_abi := "clobber_abi(" <abi> *("," <abi>) [","] ")"
  // PARSE EVERYTHING COMMITTEDLY IN THIS FUNCTION, WE CONFIRMED VIA clobber_abi
  // identifier keyword
  auto &parser = inline_asm_ctx.parser;
  auto last_token_id = inline_asm_ctx.last_token_id;
  auto &inline_asm = inline_asm_ctx.inline_asm;
  auto token = parser.peek_current_token ();
  if (!parser.skip_token (LEFT_PAREN))
    {
      token = parser.peek_current_token ();

      // TODO: Error reporting shifted to the left 1 character, I'm not sure
      // why.
      if (token->get_id () == last_token_id)
	{
	  rust_error_at (token->get_locus (),
			 "expected %<(%>, found end of macro arguments");
	  return tl::unexpected<InlineAsmParseError> (COMMITTED);
	}
      else
	{
	  rust_error_at (token->get_locus (), "expected %<(%>, found %qs",
			 token->get_token_description ());
	}
      return tl::unexpected<InlineAsmParseError> (COMMITTED);
    }

  if (parser.skip_token (RIGHT_PAREN))
    {
      rust_error_at (
	parser.peek_current_token ()->get_locus (),
	"at least one abi must be provided as an argument to %<clobber_abi%>");
      return tl::unexpected<InlineAsmParseError> (COMMITTED);
    }

  std::vector<AST::TupleClobber> new_abis;

  token = parser.peek_current_token ();

  while (token->get_id () != last_token_id && token->get_id () != RIGHT_PAREN)
    {
      // Check if it is a string literal or not, codename: <ABI> in ABNF
      if (token->get_id () == STRING_LITERAL)
	{
	  // TODO: Caring for span in here.
	  new_abis.push_back ({token->as_string (), token->get_locus ()});
	}
      else
	{
	  // TODO: We encountered something that is not string literal, which
	  // should be illegal, please emit the correct error
	  // https://github.com/rust-lang/rust/blob/b92758a9aef1cef7b79e2b72c3d8ba113e547f89/compiler/rustc_builtin_macros/src/asm.rs#L387
	  rust_unreachable ();
	}

      if (parser.skip_token (RIGHT_PAREN))
	{
	  break;
	}

      if (!parser.skip_token (COMMA))
	{
	  // TODO: If the skip of comma is unsuccessful, which should be
	  // illegal, pleaes emit the correct error.
	  rust_unreachable ();
	  return tl::unexpected<InlineAsmParseError> (COMMITTED);
	}

      token = parser.peek_current_token ();
    }

  // Done processing the local clobber abis, push that to the main Args in
  // argument

  for (auto abi : new_abis)
    {
      inline_asm.clobber_abi.push_back (abi);
    }

  return inline_asm_ctx;
}

tl::optional<AST::InlineAsmRegOrRegClass>
parse_reg (InlineAsmContext &inline_asm_ctx)
{
  using RegType = AST::InlineAsmRegOrRegClass::Type;
  auto &parser = inline_asm_ctx.parser;

  if (!parser.skip_token (LEFT_PAREN))
    {
      // TODO: we expect a left parenthesis here, please return the correct
      // error.
      rust_unreachable ();
      return tl::nullopt;
    }

  // after successful left parenthesis parsing, we should return ast of
  // InlineAsmRegOrRegClass of reg or reg class
  auto token = parser.peek_current_token ();
  AST::InlineAsmRegOrRegClass reg_class;
  if (parser.skip_token (IDENTIFIER))
    {
      // construct a InlineAsmRegOrRegClass
      reg_class.type = RegType::RegClass;
      reg_class.reg_class.Symbol = token->as_string ();
    }
  else if (parser.skip_token (STRING_LITERAL))
    {
      // TODO: there is STRING_LITERAL, and BYTE_STRING_LITERAL, should we check
      // for both?

      // construct a InlineAsmRegOrRegClass
      // parse_format_string
      reg_class.type = RegType::Reg;
      inline_asm_ctx.is_explicit = true;
      reg_class.reg_class.Symbol = token->as_string ();
    }
  else
    {
      // TODO: This should emit error
      //  return
      //  Err(p.dcx().create_err(errors::ExpectedRegisterClassOrExplicitRegister
      //  {
      //           span: p.token.span,
      //       }));
      rust_unreachable ();
    }
  if (!parser.skip_token (RIGHT_PAREN))
    {
      // TODO: we expect a left parenthesis here, please return the correct
      // error.
      rust_unreachable ();
      return tl::nullopt;
    }

  return reg_class;
}

// From rustc
tl::expected<InlineAsmContext, InlineAsmParseError>
parse_reg_operand (InlineAsmContext inline_asm_ctx)
{
  // let name = if p.token.is_ident() && p.look_ahead(1, |t| *t == token::Eq) {
  //           let (ident, _) = p.token.ident().unwrap();
  //           p.bump();
  //           p.expect(&token::Eq)?;
  //           allow_templates = false;
  //           Some(ident.name)
  //       } else {
  //           None
  //       };
  auto &parser = inline_asm_ctx.parser;
  auto token = parser.peek_current_token ();
  auto iden_token = parser.peek_current_token ();

  tl::optional<std::string> name = tl::nullopt;
  if (check_identifier (parser, ""))
    {
      auto equal_token = parser.peek_current_token ();

      if (parser.skip_token (EQUAL))
	{
	  name = token->as_string ();
	}
      else
	{
	  rust_error_at (token->get_locus (),
			 "expected operand, %s, options, or "
			 "additional template string",
			 "clobber_abi");
	  return tl::unexpected<InlineAsmParseError> (COMMITTED);
	}
    }

  int slot = inline_asm_ctx.inline_asm.operands.size ();

  // Here is all parse_reg_operand functions we're using in a for loop
  auto parse_funcs = {parse_reg_operand_in,	   parse_reg_operand_out,
		      parse_reg_operand_lateout,   parse_reg_operand_inout,
		      parse_reg_operand_const,	   parse_reg_operand_sym,
		      parse_reg_operand_unexpected};

  // Loop over and execute the parsing functions, if the parser successfullly
  // parses or if the parser fails to parse while it has committed to a token,
  // we propogate the result.
  int count = 0;
  tl::expected<InlineAsmContext, InlineAsmParseError> parsing_operand (
    inline_asm_ctx);
  for (auto &parse_func : parse_funcs)
    {
      count++;
      auto result = parsing_operand.and_then (parse_func);

      // Per rust's asm.rs's structure
      // After we've parse successfully, we break out and do a local validation
      // of named, positional & explicit register operands

      if (result.has_value ())
	{
	  inline_asm_ctx = *result;
	  break;
	}
      else if (result.error () == COMMITTED)
	{
	  if (parse_func == parse_reg_operand_unexpected)
	    return inline_asm_ctx;
	  else
	    return result;
	}
    }

  auto &inline_asm = inline_asm_ctx.inline_asm;

  token = inline_asm_ctx.parser.peek_current_token ();
  rust_debug_loc (token->get_locus (), "Here\n");
  if (inline_asm_ctx.is_explicit)
    {
      if (name != tl::nullopt)
	{
	  rust_error_at (token->get_locus (),
			 "explicit register arguments cannot have names");
	  return tl::unexpected<InlineAsmParseError> (COMMITTED);
	}
      inline_asm.reg_args.insert (slot);
    }
  else if (name != tl::nullopt)
    {
      if (inline_asm.named_args.find (name.value ())
	  != inline_asm.named_args.end ())
	{
	  rust_error_at (token->get_locus (), "duplicate argument named %qs",
			 name.value ().c_str ());
	  return tl::unexpected<InlineAsmParseError> (COMMITTED);
	}
      inline_asm.named_args[name.value ()] = slot;
    }
  else
    {
      if (!inline_asm.named_args.empty () || !inline_asm.reg_args.empty ())
	{
	  // positional arguments cannot follow named arguments or explicit
	  // register arguments
	  rust_error_at (token->get_locus (),
			 "positional arguments cannot follow named arguments "
			 "or explicit register arguments");
	  return tl::unexpected<InlineAsmParseError> (COMMITTED);
	}
    }

  return inline_asm_ctx;
}

tl::expected<InlineAsmContext, InlineAsmParseError>
parse_reg_operand_in (InlineAsmContext inline_asm_ctx)
{
  // For the keyword IN, currently we count it as a seperate keyword called
  // Rust::IN search for #define RS_TOKEN_LIST in code base.
  auto &parser = inline_asm_ctx.parser;
  location_t locus = parser.peek_current_token ()->get_locus ();
  if (!inline_asm_ctx.is_global_asm () && parser.skip_token (IN))
    {
      auto reg = parse_reg (inline_asm_ctx);

      if (parser.skip_token (UNDERSCORE))
	{
	  // We are sure to be failing a test here, based on asm.rs
	  // https://github.com/rust-lang/rust/blob/a330e49593ee890f9197727a3a558b6e6b37f843/compiler/rustc_builtin_macros/src/asm.rs#L112
	  rust_unreachable ();
	  return tl::unexpected<InlineAsmParseError> (COMMITTED);
	}

      auto expr = parser.parse_expr ();

      // TODO: When we've succesfully parse an expr, remember to clone_expr()
      // instead of nullptr
      struct AST::InlineAsmOperand::In in (reg, std::move (expr));
      inline_asm_ctx.inline_asm.operands.emplace_back (in, locus);
      return inline_asm_ctx;
    }
  return tl::unexpected<InlineAsmParseError> (NONCOMMITED);
}

tl::expected<InlineAsmContext, InlineAsmParseError>
parse_reg_operand_out (InlineAsmContext inline_asm_ctx)
{
  auto &parser = inline_asm_ctx.parser;
  location_t locus = parser.peek_current_token ()->get_locus ();
  if (!inline_asm_ctx.is_global_asm () && check_identifier (parser, "out"))
    {
      auto reg = parse_reg (inline_asm_ctx);
      std::unique_ptr<AST::Expr> expr = parser.parse_expr ();

      rust_assert (expr != nullptr);

      /*auto expr_ptr =
	 std::make_unique<AST::Expr>(AST::LiteralExpr(Literal))*/

      // TODO: When we've succesfully parse an expr, remember to clone_expr()
      // instead of nullptr
      struct AST::InlineAsmOperand::Out out (reg, false, std::move (expr));

      inline_asm_ctx.inline_asm.operands.emplace_back (out, locus);

      return inline_asm_ctx;
    }

  return tl::unexpected<InlineAsmParseError> (NONCOMMITED);
}

tl::expected<InlineAsmContext, InlineAsmParseError>
parse_reg_operand_lateout (InlineAsmContext inline_asm_ctx)
{
  auto &parser = inline_asm_ctx.parser;
  auto token = parser.peek_current_token ();
  if (!inline_asm_ctx.is_global_asm () && check_identifier (parser, "lateout"))
    {
      rust_error_at (token->get_locus (),
		     "The lateout feature is not implemented");
      rust_unreachable ();
      return tl::unexpected<InlineAsmParseError> (COMMITTED);
    }

  return tl::unexpected<InlineAsmParseError> (NONCOMMITED);
}

tl::expected<InlineAsmContext, InlineAsmParseError>
parse_reg_operand_inout (InlineAsmContext inline_asm_ctx)
{
  auto &parser = inline_asm_ctx.parser;
  auto token = parser.peek_current_token ();

  if (!inline_asm_ctx.is_global_asm () && check_identifier (parser, "inout"))
    {
      auto reg = parse_reg (inline_asm_ctx);

      if (parser.skip_token (UNDERSCORE))
	{
	  // We are sure to be failing a test here, based on asm.rs
	  // https://github.com/rust-lang/rust/blob/a330e49593ee890f9197727a3a558b6e6b37f843/compiler/rustc_builtin_macros/src/asm.rs#L112
	  rust_error_at (token->get_locus (),
			 "The lateout feature is not implemented");
	  rust_unreachable ();
	  return tl::unexpected<InlineAsmParseError> (COMMITTED);
	}

      // TODO: Is error propogation our top priority, the ? in rust's asm.rs is
      // doing a lot of work.
      // TODO: Not sure how to use parse_expr
      if (!check_identifier (parser, ""))
	rust_unreachable ();
      // auto expr = parse_format_string (inline_asm_ctx);

      std::unique_ptr<AST::Expr> out_expr;

      if (parser.skip_token (MATCH_ARROW))
	{
	  if (!parser.skip_token (UNDERSCORE))
	    {
	      // auto result = parse_format_string (inline_asm_ctx);

	      if (!check_identifier (parser, ""))
		rust_unreachable ();
	      // out_expr = parser.parse_expr();
	    }

	  // TODO: Rembmer to pass in clone_expr() instead of nullptr
	  // https://github.com/rust-lang/rust/blob/a3167859f2fd8ff2241295469876a2b687280bdc/compiler/rustc_builtin_macros/src/asm.rs#L135
	  // RUST VERSION: ast::InlineAsmOperand::SplitInOut { reg, in_expr:
	  // expr, out_expr, late: false }
	  //	  struct AST::InlineAsmOperand::SplitInOut split_in_out (reg,
	  // false, nullptr,
	  // nullptr);
	  // inline_asm_ctx.inline_asm.operands.push_back (split_in_out);

	  return inline_asm_ctx;
	}
      else
	{
	  // https://github.com/rust-lang/rust/blob/a3167859f2fd8ff2241295469876a2b687280bdc/compiler/rustc_builtin_macros/src/asm.rs#L137
	  // RUST VERSION: ast::InlineAsmOperand::InOut { reg, expr, late: false
	  // }
	  //	  struct AST::InlineAsmOperand::InOut inout (reg, false,
	  // nullptr);
	  //	  inline_asm_ctx.inline_asm.operands.push_back (inout);
	  return inline_asm_ctx;
	}
    }

  return tl::unexpected<InlineAsmParseError> (NONCOMMITED);
}

tl::expected<InlineAsmContext, InlineAsmParseError>
parse_reg_operand_const (InlineAsmContext inline_asm_ctx)
{
  auto &parser = inline_asm_ctx.parser;
  if (parser.peek_current_token ()->get_id () == CONST)
    {
      // TODO: Please handle const with parse_expr instead.
      auto anon_const = parse_format_string (inline_asm_ctx);
      rust_unreachable ();
      return tl::unexpected<InlineAsmParseError> (COMMITTED);
    }

  return tl::unexpected<InlineAsmParseError> (NONCOMMITED);
}

tl::expected<InlineAsmContext, InlineAsmParseError>
parse_reg_operand_sym (InlineAsmContext inline_asm_ctx)
{
  auto &parser = inline_asm_ctx.parser;

  if (check_identifier (parser, "sym"))
    {
      // TODO: Please handle sym, which needs ExprKind::Path in Rust's asm.rs
      rust_unreachable ();
      return tl::unexpected<InlineAsmParseError> (COMMITTED);
    }
  return tl::unexpected<InlineAsmParseError> (NONCOMMITED);
}

tl::expected<InlineAsmContext, InlineAsmParseError>
parse_reg_operand_unexpected (InlineAsmContext inline_asm_ctx)
{
  auto token = inline_asm_ctx.parser.peek_current_token ();
  // TODO: It is  weird that we can't seem to match any identifier,
  // something must be wrong. consult compiler code in asm.rs or rust online
  // compiler.
  // rust_unreachable ();

  // rust_error_at (token->get_locus (), "ERROR RIGHT HERE");
  return tl::unexpected<InlineAsmParseError> (COMMITTED);
}

void
check_and_set (InlineAsmContext &inline_asm_ctx, AST::InlineAsmOption option)
{
  auto &parser = inline_asm_ctx.parser;
  auto &inline_asm = inline_asm_ctx.inline_asm;
  if (inline_asm.options.count (option) != 0)
    {
      // TODO: report an error of duplication
      rust_error_at (parser.peek_current_token ()->get_locus (),
		     "the %qs option was already provided",
		     InlineAsmOptionMap[option].c_str ());
      return;
    }
  else
    {
      inline_asm.options.insert (option);
    }
}
tl::expected<InlineAsmContext, InlineAsmParseError>
parse_options (InlineAsmContext &inline_asm_ctx)
{
  auto &parser = inline_asm_ctx.parser;
  bool is_global_asm = inline_asm_ctx.inline_asm.is_global_asm;
  // Parse everything commitedly
  if (!parser.skip_token (LEFT_PAREN))
    {
      auto local_token = parser.peek_current_token ();
      rust_error_at (local_token->get_locus (), "expected %qs, found %qs", "(",
		     local_token->as_string ().c_str ());
      return tl::unexpected<InlineAsmParseError> (COMMITTED);
    }

  auto token = parser.peek_current_token ();
  while (!parser.skip_token (RIGHT_PAREN))
    {
      if (!is_global_asm && check_identifier (parser, "pure"))
	{
	  check_and_set (inline_asm_ctx, AST::InlineAsmOption::PURE);
	}
      else if (!is_global_asm && check_identifier (parser, "nomem"))
	{
	  check_and_set (inline_asm_ctx, AST::InlineAsmOption::NOMEM);
	}
      else if (!is_global_asm && check_identifier (parser, "readonly"))
	{
	  check_and_set (inline_asm_ctx, AST::InlineAsmOption::READONLY);
	}
      else if (!is_global_asm && check_identifier (parser, "preserves_flags"))
	{
	  check_and_set (inline_asm_ctx, AST::InlineAsmOption::PRESERVES_FLAGS);
	}
      else if (!is_global_asm && check_identifier (parser, "noreturn"))
	{
	  check_and_set (inline_asm_ctx, AST::InlineAsmOption::NORETURN);
	}
      else if (!is_global_asm && check_identifier (parser, "nostack"))
	{
	  check_and_set (inline_asm_ctx, AST::InlineAsmOption::NOSTACK);
	}
      else if (!is_global_asm && check_identifier (parser, "may_unwind"))
	{
	  check_and_set (inline_asm_ctx, AST::InlineAsmOption::MAY_UNWIND);
	}
      else if (check_identifier (parser, "att_syntax"))
	{
	  check_and_set (inline_asm_ctx, AST::InlineAsmOption::ATT_SYNTAX);
	}
      else if (check_identifier (parser, "raw"))
	{
	  check_and_set (inline_asm_ctx, AST::InlineAsmOption::RAW);
	}
      else
	{
	  rust_error_at (token->get_locus (),
			 "expected one of %qs, %qs, %qs, %qs, %qs, %qs, %qs, "
			 "%qs, %qs, or %qs, found %qs",
			 ")", "att_syntax", "may_unwind", "nomem", "noreturn",
			 "nostack", "preserves_flags", "pure", "raw",
			 "readonly", token->as_string ().c_str ());
	  return tl::unexpected<InlineAsmParseError> (COMMITTED);
	}
      if (parser.skip_token (RIGHT_PAREN))
	{
	  break;
	}

      // Parse comma as optional
      if (parser.skip_token (COMMA))
	continue;
      else
	{
	  rust_unreachable ();
	  token = parser.peek_current_token ();
	  return tl::unexpected<InlineAsmParseError> (COMMITTED);
	}
    }

  // TODO: Per rust asm.rs regarding options_spans
  // I'm guessing this has to do with some error reporting.
  // let new_span = span_start.to(p.prev_token.span);
  // args.options_spans.push(new_span);

  return inline_asm_ctx;
}

bool
check_identifier (Parser<MacroInvocLexer> &p, std::string ident)
{
  auto token = p.peek_current_token ();

  if (token->get_id () == IDENTIFIER)
    {
      auto str = token->as_string ();

      // For non-promoted keywords, we need to also check for them.

      if (str == ident)
	{
	  p.skip_token ();
	  return true;
	}
      if (ident == "")
	{
	  if (potentially_nonpromoted_keywords.find (str)
	      == potentially_nonpromoted_keywords.end ())
	    {
	      p.skip_token ();
	      return true;
	    }
	  return false;
	}
    }

  return false;
}

tl::optional<std::string>
parse_format_string (InlineAsmContext &inline_asm_ctx)
{
  auto &parser = inline_asm_ctx.parser;
  auto last_token_id = inline_asm_ctx.last_token_id;
  auto token = parser.peek_current_token ();

  if (token->get_id () != last_token_id && token->get_id () == STRING_LITERAL)
    {
      // very nice, we got a supposedly formatted string.
      parser.skip_token ();
      return token->as_string ();
    }
  else
    {
      return tl::nullopt;
    }
}

tl::optional<AST::Fragment>
MacroBuiltin::asm_handler (location_t invoc_locus, AST::MacroInvocData &invoc,
			   AST::InvocKind semicolon, AST::AsmKind is_global_asm)
{
  return parse_asm (invoc_locus, invoc, semicolon, is_global_asm);
}

tl::expected<InlineAsmContext, InlineAsmParseError>
parse_asm_arg (InlineAsmContext inline_asm_ctx)
{
  auto &parser = inline_asm_ctx.parser;
  auto last_token_id = inline_asm_ctx.last_token_id;
  auto token = parser.peek_current_token ();
  tl::optional<std::string> fm_string;
  while (token->get_id () != last_token_id)
    {
      token = parser.peek_current_token ();

      // We accept a comma token here.
      if (token->get_id () != COMMA
	  && inline_asm_ctx.consumed_comma_without_formatted_string)
	{
	  // if it is not a comma, but we consumed it previously, this is fine
	  // but we have to set it to false tho.
	  inline_asm_ctx.consumed_comma_without_formatted_string = false;
	}
      else if (token->get_id () == COMMA
	       && !inline_asm_ctx.consumed_comma_without_formatted_string)
	{
	  inline_asm_ctx.consumed_comma_without_formatted_string = false;
	  parser.skip_token ();
	}
      else if (token->get_id () == COMMA
	       && inline_asm_ctx.consumed_comma_without_formatted_string)
	{
	  // We consumed comma, and there happens to also be a comma
	  // error should be: expected expression, found `,`
	  rust_error_at (token->get_locus (), "expected expression, found %qs",
			 ",");
	  return tl::unexpected<InlineAsmParseError> (COMMITTED);
	  break;
	}

      // And if that token comma is also the trailing comma, we break
      token = parser.peek_current_token ();
      if (token->get_id () == COMMA && token->get_id () == last_token_id)
	{
	  parser.skip_token ();
	  break;
	}

      // Ok after the left paren is good, we better be parsing correctly
      // everything in here, which is operand in ABNF

      // Parse clobber abi, eat the identifier named "clobber_abi" if true
      if (check_identifier (parser, "clobber_abi"))
	{
	  auto expected = parse_clobber_abi (inline_asm_ctx);
	  if (expected.has_value ())
	    continue;
	  else if (expected.error () == COMMITTED)
	    return expected;

	  // The error type is definitely non-committed (we have checked above),
	  // we are allowed to keep on parsing
	}

      if (check_identifier (parser, "options"))
	{
	  auto expected = parse_options (inline_asm_ctx);
	  if (expected.has_value ())
	    continue;
	  else if (expected.error () == COMMITTED)
	    return expected;

	  // The error type is definitely non-committed (we have checked above),
	  // we are allowed to keep on parsing
	}

      // Ok after we have check that neither clobber_abi nor options works, the
      // only other logical choice is reg_operand

      auto expected = parse_reg_operand (inline_asm_ctx);
      if (expected.has_value ())
	continue;
      else if (expected.error () == COMMITTED)
	return expected;

      // Since parse_reg_operand is the last thing we've considered,
      // The non-committed parse error type means that we have exhausted our
      // search path

      // We then should return the error of COMMITTED, even though we have not
      // committed to anything So that the error bubbles up and we recover from
      // this error gracefully
      rust_error_at (token->get_locus (),
		     "expected operand, %s, options, or additional "
		     "template string",
		     "clobber_abi");
      return tl::unexpected<InlineAsmParseError> (COMMITTED);
    }
  return tl::expected<InlineAsmContext, InlineAsmParseError> (inline_asm_ctx);
}

tl::expected<InlineAsmContext, InlineAsmParseError>
expand_inline_asm_strings (InlineAsmContext inline_asm_ctx)
{
  auto &inline_asm = inline_asm_ctx.inline_asm;

  auto str_vec = inline_asm.get_template_strs ();

  decltype (str_vec) resulting_template_vec;
  for (auto &template_str : str_vec)
    {
      /*std::cout << template_str.symbol << std::endl;*/

      auto pieces = Fmt::Pieces::collect (template_str.symbol, false,
					  Fmt::ffi::ParseMode::InlineAsm);
      auto pieces_vec = pieces.get_pieces ();

      std::string transformed_template_str = "";
      for (size_t i = 0; i < pieces_vec.size (); i++)
	{
	  auto piece = pieces_vec[i];
	  if (piece.tag == Fmt::ffi::Piece::Tag::String)
	    {
	      transformed_template_str += piece.string._0.to_string ();
	    }
	  else if (piece.tag == Fmt::ffi::Piece::Tag::NextArgument)
	    {
	      /*    std::cout << "       " << i << ": "*/
	      /*<< piece.next_argument._0.to_string () << std::endl;*/

	      auto next_argument = piece.next_argument._0;
	      switch (piece.next_argument._0.position.tag)
		{
		  case Fmt::ffi::Position::Tag::ArgumentImplicitlyIs: {
		    auto idx = next_argument.position.argument_implicitly_is._0;
		    /*auto trait = next_argument.format;*/
		    /*auto arg = arguments.at (idx);*/

		    /* // FIXME(Arthur): This API sucks*/
		    /* rust_assert (arg.get_kind ().kind*/
		    /*== AST::FormatArgumentKind::Kind::Normal);*/
		    /**/
		    /* args.push_back ({arg.get_expr ().clone_expr (),
		     * trait});*/

		    transformed_template_str += "%" + std::to_string (idx);
		    // std::cout << "argument implicitly is: " << idx <<
		    // std::endl; std::cout << "transformed template str is:"
		    // << transformed_template_str << std::endl;
		    /*std::cout << "trait: " << trait.to_string () <<
		     * std::endl;*/
		    /*std::cout << "arg: " << arg.to_string () << std::endl;*/
		  }
		  break;
		case Fmt::ffi::Position::Tag::ArgumentIs:
		case Fmt::ffi::Position::Tag::ArgumentNamed:
		  rust_sorry_at (inline_asm.get_locus (),
				 "unhandled argument position specifier");
		  break;
		}
	    }
	}
      template_str.symbol = transformed_template_str;
    }

  inline_asm.template_strs = str_vec;
  return inline_asm_ctx;
}

tl::optional<AST::Fragment>
parse_asm (location_t invoc_locus, AST::MacroInvocData &invoc,
	   AST::InvocKind semicolon, AST::AsmKind is_global_asm)
{
  // From the rule of asm.
  // We first parse all formatted strings. If we fail, then we return
  // tl::nullopt

  // We then parse the asm arguments. If we fail, then we return
  // tl::nullopt

  // We then validate. If we fail, then we return tl::nullopt

  // Done
  MacroInvocLexer lex (invoc.get_delim_tok_tree ().to_token_stream ());
  Parser<MacroInvocLexer> parser (lex);
  auto last_token_id = macro_end_token (invoc.get_delim_tok_tree (), parser);

  AST::InlineAsm inline_asm (invoc_locus,
			     is_global_asm == AST::AsmKind::Global);
  auto inline_asm_ctx = InlineAsmContext (inline_asm, parser, last_token_id);

  auto resulting_context = parse_format_strings (inline_asm_ctx)
			     .and_then (parse_asm_arg)
			     .and_then (validate)
			     .and_then (expand_inline_asm_strings);

  // TODO: I'm putting the validation here because the rust reference put
  // it here Per Arthur's advice we would actually do the validation in a
  // different stage. and visit on the InlineAsm AST instead of it's
  // context.
  if (resulting_context)
    {
      auto node = (*resulting_context).inline_asm.clone_expr_without_block ();

      std::vector<AST::SingleASTNode> single_vec = {};

      // If the macro invocation has a semicolon (`asm!("...");`), then we
      // need to make it a statement. This way, it will be expanded
      // properly.
      if (semicolon == AST::InvocKind::Semicoloned)
	single_vec.emplace_back (AST::SingleASTNode (
	  Rust::make_unique<AST::ExprStmt> (std::move (node), invoc_locus,
					    semicolon
					      == AST::InvocKind::Semicoloned)));
      else
	single_vec.emplace_back (AST::SingleASTNode (std::move (node)));

      AST::Fragment fragment_ast
	= AST::Fragment (single_vec,
			 std::vector<std::unique_ptr<AST::Token>> ());
      return fragment_ast;
    }
  else
    {
      return tl::nullopt;
    }
}

tl::expected<InlineAsmContext, InlineAsmParseError>
parse_format_strings (InlineAsmContext inline_asm_ctx)
{
  // Parse the first ever formatted string, success or not, will skip 1
  // token
  auto &parser = inline_asm_ctx.parser;
  auto last_token_id = inline_asm_ctx.last_token_id;
  auto fm_string = parse_format_string (inline_asm_ctx);

  auto &inline_asm = inline_asm_ctx.inline_asm;
  auto token = parser.peek_current_token ();
  if (fm_string == tl::nullopt)
    {
      rust_error_at (parser.peek_current_token ()->get_locus (),
		     "%s template must be a string literal", "asm");
      return tl::unexpected<InlineAsmParseError> (COMMITTED);
    }
  else
    {
      auto template_str
	= AST::TupleTemplateStr (token->get_locus (),
				 strip_double_quotes (fm_string.value ()));
      inline_asm.template_strs.push_back (template_str);
    }

  // formatted string stream

  while (parser.peek_current_token ()->get_id () != last_token_id)
    {
      if (!parser.skip_token (COMMA))
	{
	  break;
	}
      // Ok after the comma is good, we better be parsing correctly
      // everything in here, which is formatted string in ABNF
      inline_asm_ctx.consumed_comma_without_formatted_string = false;

      token = parser.peek_current_token ();
      fm_string = parse_format_string (inline_asm_ctx);
      if (fm_string == tl::nullopt)
	{
	  inline_asm_ctx.consumed_comma_without_formatted_string = true;
	  break;
	}
      else
	{
	  auto template_str
	    = AST::TupleTemplateStr (token->get_locus (),
				     strip_double_quotes (fm_string.value ()));
	  inline_asm.template_strs.push_back (template_str);
	}
    }

  return inline_asm_ctx;
}

// bool
// is_label (const std::string &potential_label)
// {

//   if (potential_label.empty () || potential_label.back () != ':')
//     return false;

//   // Check if all characters before the last colon are digits
//   for (size_t i = 0; i < potential_label.length () - 1; i++)
//   {
//     if (potential_label[i] < '0' || potential_label[i] > '9')
//       return false;
//   }

//   return true;
// }

tl::expected<InlineAsmContext, InlineAsmParseError>
validate (InlineAsmContext inline_asm_ctx)
{
  return tl::expected<InlineAsmContext, InlineAsmParseError> (inline_asm_ctx);
}
} // namespace Rust