1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
|
/* Localize comdats.
Copyright (C) 2014 Free Software Foundation, Inc.
This file is part of GCC.
GCC is free software; you can redistribute it and/or modify it under
the terms of the GNU General Public License as published by the Free
Software Foundation; either version 3, or (at your option) any later
version.
GCC is distributed in the hope that it will be useful, but WITHOUT ANY
WARRANTY; without even the implied warranty of MERCHANTABILITY or
FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
for more details.
You should have received a copy of the GNU General Public License
along with GCC; see the file COPYING3. If not see
<http://www.gnu.org/licenses/>. */
/* This is very simple pass that looks for static symbols that are used
exlusively by symbol within one comdat group. In this case it makes
sense to bring the symbol itself into the group to avoid dead code
that would arrise when the comdat group from current unit is replaced
by a different copy. Consider for example:
static int q(void)
{
....
}
inline int t(void)
{
return q();
}
if Q is used only by T, it makes sense to put Q into T's comdat group.
The pass solve simple dataflow across the callgraph trying to prove what
symbols are used exclusively from a given comdat group.
The implementation maintains a queue linked by AUX pointer terminated by
pointer value 1. Lattice values are NULL for TOP, actual comdat group, or
ERROR_MARK_NODE for bottom.
TODO: When symbol is used only by comdat symbols, but from different groups,
it would make sense to produce a new comdat group for it with anonymous name.
TODO2: We can't mix variables and functions within one group. Currently
we just give up on references of symbols of different types. We also should
handle this by anonymous comdat group section. */
#include "config.h"
#include "system.h"
#include "coretypes.h"
#include "tm.h"
#include "tree.h"
#include "cgraph.h"
#include "tree-pass.h"
#include "hash-map.h"
/* Main dataflow loop propagating comdat groups across
the symbol table. All references to SYMBOL are examined
and NEWGROUP is updated accordingly. MAP holds current lattice
values for individual symbols. */
tree
propagate_comdat_group (struct symtab_node *symbol,
tree newgroup, hash_map<symtab_node *, tree> &map)
{
int i;
struct ipa_ref *ref;
/* Walk all references to SYMBOL, recursively dive into aliases. */
for (i = 0;
symbol->iterate_referring (i, ref)
&& newgroup != error_mark_node; i++)
{
struct symtab_node *symbol2 = ref->referring;
if (ref->use == IPA_REF_ALIAS)
{
newgroup = propagate_comdat_group (symbol2, newgroup, map);
continue;
}
/* One COMDAT group can not hold both variables and functions at
a same time. For now we just go to BOTTOM, in future we may
invent special comdat groups for this case. */
if (symbol->type != symbol2->type)
{
newgroup = error_mark_node;
break;
}
/* If we see inline clone, its comdat group actually
corresponds to the comdat group of the function it is inlined
to. */
if (cgraph_node * cn = dyn_cast <cgraph_node *> (symbol2))
{
if (cn->global.inlined_to)
symbol2 = cn->global.inlined_to;
}
/* The actual merge operation. */
tree *val2 = map.get (symbol2);
if (val2 && *val2 != newgroup)
{
if (!newgroup)
newgroup = *val2;
else
newgroup = error_mark_node;
}
}
/* If we analyze function, walk also callers. */
cgraph_node *cnode = dyn_cast <cgraph_node *> (symbol);
if (cnode)
for (struct cgraph_edge * edge = cnode->callers;
edge && newgroup != error_mark_node; edge = edge->next_caller)
{
struct symtab_node *symbol2 = edge->caller;
/* If we see inline clone, its comdat group actually
corresponds to the comdat group of the function it is inlined
to. */
if (cgraph_node * cn = dyn_cast <cgraph_node *> (symbol2))
{
if (cn->global.inlined_to)
symbol2 = cn->global.inlined_to;
}
/* The actual merge operation. */
tree *val2 = map.get (symbol2);
if (val2 && *val2 != newgroup)
{
if (!newgroup)
newgroup = *val2;
else
newgroup = error_mark_node;
}
}
return newgroup;
}
/* Add all references of SYMBOL that are defined into queue started by FIRST
and linked by AUX pointer (unless they are already enqueued).
Walk recursively inlined functions. */
void
enqueue_references (symtab_node **first,
symtab_node *symbol)
{
int i;
struct ipa_ref *ref = NULL;
for (i = 0; symbol->iterate_reference (i, ref); i++)
{
symtab_node *node = symtab_alias_ultimate_target (ref->referred, NULL);
if (!node->aux && node->definition)
{
node->aux = *first;
*first = node;
}
}
if (cgraph_node *cnode = dyn_cast <cgraph_node *> (symbol))
{
struct cgraph_edge *edge;
for (edge = cnode->callees; edge; edge = edge->next_callee)
if (!edge->inline_failed)
enqueue_references (first, edge->callee);
else
{
symtab_node *node = symtab_alias_ultimate_target (edge->callee,
NULL);
if (!node->aux && node->definition)
{
node->aux = *first;
*first = node;
}
}
}
}
/* Set comdat group of SYMBOL to GROUP.
Callback for symtab_for_node_and_aliases. */
bool
set_comdat_group (symtab_node *symbol,
void *head_p)
{
symtab_node *head = (symtab_node *)head_p;
gcc_assert (!symbol->get_comdat_group ());
symbol->set_comdat_group (head->get_comdat_group ());
symtab_add_to_same_comdat_group (symbol, head);
return false;
}
/* The actual pass with the main dataflow loop. */
static unsigned int
ipa_comdats (void)
{
hash_map<symtab_node *, tree> map (251);
hash_map<tree, symtab_node *> comdat_head_map (251);
symtab_node *symbol;
bool comdat_group_seen = false;
symtab_node *first = (symtab_node *) (void *) 1;
tree group;
/* Start the dataflow by assigning comdat group to symbols that are in comdat
groups already. All other externally visible symbols must stay, we use
ERROR_MARK_NODE as bottom for the propagation. */
FOR_EACH_DEFINED_SYMBOL (symbol)
if (!symtab_real_symbol_p (symbol))
;
else if ((group = symbol->get_comdat_group ()) != NULL)
{
map.put (symbol, group);
comdat_head_map.put (group, symbol);
comdat_group_seen = true;
/* Mark the symbol so we won't waste time visiting it for dataflow. */
symbol->aux = (symtab_node *) (void *) 1;
}
/* See symbols that can not be privatized to comdats; that is externally
visible symbols or otherwise used ones. We also do not want to mangle
user section names. */
else if (symbol->externally_visible
|| symbol->force_output
|| symbol->used_from_other_partition
|| TREE_THIS_VOLATILE (symbol->decl)
|| symbol->get_section ()
|| (TREE_CODE (symbol->decl) == FUNCTION_DECL
&& (DECL_STATIC_CONSTRUCTOR (symbol->decl)
|| DECL_STATIC_DESTRUCTOR (symbol->decl))))
{
map.put (symtab_alias_ultimate_target (symbol, NULL), error_mark_node);
/* Mark the symbol so we won't waste time visiting it for dataflow. */
symbol->aux = (symtab_node *) (void *) 1;
}
else
{
/* Enqueue symbol for dataflow. */
symbol->aux = first;
first = symbol;
}
if (!comdat_group_seen)
{
FOR_EACH_DEFINED_SYMBOL (symbol)
symbol->aux = NULL;
return 0;
}
/* The actual dataflow. */
while (first != (void *) 1)
{
tree group = NULL;
tree newgroup, *val;
symbol = first;
first = (symtab_node *)first->aux;
/* Get current lattice value of SYMBOL. */
val = map.get (symbol);
if (val)
group = *val;
/* If it is bottom, there is nothing to do; do not clear AUX
so we won't re-queue the symbol. */
if (group == error_mark_node)
continue;
newgroup = propagate_comdat_group (symbol, group, map);
/* If nothing changed, proceed to next symbol. */
if (newgroup == group)
{
symbol->aux = NULL;
continue;
}
/* Update lattice value and enqueue all references for re-visiting. */
gcc_assert (newgroup);
if (val)
*val = newgroup;
else
map.put (symbol, newgroup);
enqueue_references (&first, symbol);
/* We may need to revisit the symbol unless it is BOTTOM. */
if (newgroup != error_mark_node)
symbol->aux = NULL;
}
/* Finally assign symbols to the sections. */
FOR_EACH_DEFINED_SYMBOL (symbol)
{
symbol->aux = NULL;
if (!symbol->get_comdat_group ()
&& !symbol->alias
&& symtab_real_symbol_p (symbol))
{
tree group = *map.get (symbol);
if (group == error_mark_node)
continue;
if (dump_file)
{
fprintf (dump_file, "Localizing symbol\n");
dump_symtab_node (dump_file, symbol);
fprintf (dump_file, "To group: %s\n", IDENTIFIER_POINTER (group));
}
symtab_for_node_and_aliases (symbol, set_comdat_group,
*comdat_head_map.get (group), true);
}
}
return 0;
}
namespace {
const pass_data pass_data_ipa_comdats =
{
IPA_PASS, /* type */
"comdats", /* name */
OPTGROUP_NONE, /* optinfo_flags */
true, /* has_execute */
TV_IPA_COMDATS, /* tv_id */
0, /* properties_required */
0, /* properties_provided */
0, /* properties_destroyed */
0, /* todo_flags_start */
0, /* todo_flags_finish */
};
class pass_ipa_comdats : public ipa_opt_pass_d
{
public:
pass_ipa_comdats (gcc::context *ctxt)
: ipa_opt_pass_d (pass_data_ipa_comdats, ctxt,
NULL, /* generate_summary */
NULL, /* write_summary */
NULL, /* read_summary */
NULL, /* write_optimization_summary */
NULL, /* read_optimization_summary */
NULL, /* stmt_fixup */
0, /* function_transform_todo_flags_start */
NULL, /* function_transform */
NULL) /* variable_transform */
{}
/* opt_pass methods: */
virtual bool gate (function *);
virtual unsigned int execute (function *) { return ipa_comdats (); }
}; // class pass_ipa_comdats
bool
pass_ipa_comdats::gate (function *)
{
return optimize;
}
} // anon namespace
ipa_opt_pass_d *
make_pass_ipa_comdats (gcc::context *ctxt)
{
return new pass_ipa_comdats (ctxt);
}
|