diff options
author | Tobias Burnus <tburnus@baylibre.com> | 2024-08-08 10:42:25 +0200 |
---|---|---|
committer | Tobias Burnus <tburnus@baylibre.com> | 2024-08-08 10:42:25 +0200 |
commit | e3a6dec326a127ad549246435b9d3835e9a32407 (patch) | |
tree | d7650ba0580b709153ec04cf8da7560fc88cca0c /libgomp | |
parent | 6db7150947996f89a4a62f4579f8b817b0ca1986 (diff) | |
download | gcc-e3a6dec326a127ad549246435b9d3835e9a32407.zip gcc-e3a6dec326a127ad549246435b9d3835e9a32407.tar.gz gcc-e3a6dec326a127ad549246435b9d3835e9a32407.tar.bz2 |
libgomp.c++/static-aggr-constructor-destructor-{1,2}.C: Fix scan-tree-dump
In principle, the optimized dump should be the same on the host, but as
'nohost' is not handled, is is present. However when ENABLE_OFFLOADING is
false, it is handled early enough to remove the function.
libgomp/ChangeLog:
* testsuite/libgomp.c++/static-aggr-constructor-destructor-1.C: Split
scan-tree-dump into with and without target offload_target_any.
* testsuite/libgomp.c++/static-aggr-constructor-destructor-2.C:
Likewise.
Diffstat (limited to 'libgomp')
-rw-r--r-- | libgomp/testsuite/libgomp.c++/static-aggr-constructor-destructor-1.C | 15 | ||||
-rw-r--r-- | libgomp/testsuite/libgomp.c++/static-aggr-constructor-destructor-2.C | 16 |
2 files changed, 25 insertions, 6 deletions
diff --git a/libgomp/testsuite/libgomp.c++/static-aggr-constructor-destructor-1.C b/libgomp/testsuite/libgomp.c++/static-aggr-constructor-destructor-1.C index 403a071..b5aafc8 100644 --- a/libgomp/testsuite/libgomp.c++/static-aggr-constructor-destructor-1.C +++ b/libgomp/testsuite/libgomp.c++/static-aggr-constructor-destructor-1.C @@ -9,9 +9,18 @@ // { dg-final { scan-tree-dump-not "omp_is_initial_device" "optimized" } } // { dg-final { scan-tree-dump-not "__omp_target_static_init_and_destruction" "optimized" } } -// FIXME: should be '-not' not '-times' 1: -// { dg-final { scan-tree-dump-times "void _GLOBAL__off_I_v1" 1 "optimized" } } -// { dg-final { scan-tree-dump-times "__attribute__\\(\\(\[^\n\r]*omp declare target nohost" 1 "optimized" } } + +// (A) No offloading configured: The symbols aren't present +// Caveat: They are present with -foffload=disable - or offloading +// configured but none of the optional offload packages/binaries installed. +// But the 'offload_target_any' check cannot distinguish those +// { dg-final { scan-tree-dump-not "void _GLOBAL__off_I_v1" "optimized" { target { ! offload_target_any } } } } +// { dg-final { scan-tree-dump-not "__attribute__\\(\\(\[^\n\r]*omp declare target nohost" "optimized" { target { ! offload_target_any } } } } + +// (B) With offload configured (and compiling for an offload target) +// the symbols are present (missed optimization). Hence: FIXME. +// { dg-final { scan-tree-dump-times "void _GLOBAL__off_I_v1" 1 "optimized" { target offload_target_any } } } +// { dg-final { scan-tree-dump-times "__attribute__\\(\\(\[^\n\r]*omp declare target nohost" 1 "optimized" { target offload_target_any } } } // { dg-final { only_for_offload_target amdgcn-amdhsa scan-offload-tree-dump-not "omp_initial_device;" "optimized" { target offload_target_amdgcn } } } // { dg-final { only_for_offload_target amdgcn-amdhsa scan-offload-tree-dump "v1\\._x = 5;" "optimized" { target offload_target_amdgcn } } } diff --git a/libgomp/testsuite/libgomp.c++/static-aggr-constructor-destructor-2.C b/libgomp/testsuite/libgomp.c++/static-aggr-constructor-destructor-2.C index 6dd4260..9652a72 100644 --- a/libgomp/testsuite/libgomp.c++/static-aggr-constructor-destructor-2.C +++ b/libgomp/testsuite/libgomp.c++/static-aggr-constructor-destructor-2.C @@ -9,9 +9,19 @@ // { dg-final { scan-tree-dump-not "omp_is_initial_device" "optimized" } } // { dg-final { scan-tree-dump-not "__omp_target_static_init_and_destruction" "optimized" } } -// FIXME: should be '-not' not '-times' 1: -// { dg-final { scan-tree-dump-times "void _GLOBAL__off_I_" 1 "optimized" } } -// { dg-final { scan-tree-dump-times "__attribute__\\(\\(\[^\n\r]*omp declare target nohost" 1 "optimized" } } + +// (A) No offloading configured: The symbols aren't present +// Caveat: They are present with -foffload=disable - or offloading +// configured but none of the optional offload packages/binaries installed. +// But the 'offload_target_any' check cannot distinguish those +// { dg-final { scan-tree-dump-not "void _GLOBAL__off_I_v1" "optimized" { target { ! offload_target_any } } } } +// { dg-final { scan-tree-dump-not "__attribute__\\(\\(\[^\n\r]*omp declare target nohost" "optimized" { target { ! offload_target_any } } } } + +// (B) With offload configured (and compiling for an offload target) +// the symbols are present (missed optimization). Hence: FIXME. +// { dg-final { scan-tree-dump-times "void _GLOBAL__off_I_v1" 1 "optimized" { target offload_target_any } } } +// { dg-final { scan-tree-dump-times "__attribute__\\(\\(\[^\n\r]*omp declare target nohost" 1 "optimized" { target offload_target_any } } } + // { dg-final { only_for_offload_target amdgcn-amdhsa scan-offload-tree-dump-not "omp_initial_device;" "optimized" { target offload_target_amdgcn } } } // { dg-final { only_for_offload_target amdgcn-amdhsa scan-offload-tree-dump "v1\\._x = 5;" "optimized" { target offload_target_amdgcn } } } |