diff options
author | Ian Lance Taylor <ian@gcc.gnu.org> | 2014-07-19 08:53:52 +0000 |
---|---|---|
committer | Ian Lance Taylor <ian@gcc.gnu.org> | 2014-07-19 08:53:52 +0000 |
commit | 00d86ac99f5dd6afa5bbd7c38ffe1c585edd2387 (patch) | |
tree | b988e32ea14a3dc1b4718b1fdfa47bab087ae96c /libgo/go/io | |
parent | bcf2fc6ee0a7edbe7de4299f28b66527c07bb0a2 (diff) | |
download | gcc-00d86ac99f5dd6afa5bbd7c38ffe1c585edd2387.zip gcc-00d86ac99f5dd6afa5bbd7c38ffe1c585edd2387.tar.gz gcc-00d86ac99f5dd6afa5bbd7c38ffe1c585edd2387.tar.bz2 |
libgo: Update to Go 1.3 release.
From-SVN: r212837
Diffstat (limited to 'libgo/go/io')
-rw-r--r-- | libgo/go/io/io.go | 1 | ||||
-rw-r--r-- | libgo/go/io/multi.go | 8 | ||||
-rw-r--r-- | libgo/go/io/multi_test.go | 27 |
3 files changed, 34 insertions, 2 deletions
diff --git a/libgo/go/io/io.go b/libgo/go/io/io.go index f7073ff..022fdb6 100644 --- a/libgo/go/io/io.go +++ b/libgo/go/io/io.go @@ -74,6 +74,7 @@ type Reader interface { // It returns the number of bytes written from p (0 <= n <= len(p)) // and any error encountered that caused the write to stop early. // Write must return a non-nil error if it returns n < len(p). +// Write must not modify the slice data, even temporarily. type Writer interface { Write(p []byte) (n int, err error) } diff --git a/libgo/go/io/multi.go b/libgo/go/io/multi.go index ab8dd5d..e26cc53 100644 --- a/libgo/go/io/multi.go +++ b/libgo/go/io/multi.go @@ -29,7 +29,9 @@ func (mr *multiReader) Read(p []byte) (n int, err error) { // inputs have returned EOF, Read will return EOF. If any of the readers // return a non-nil, non-EOF error, Read will return that error. func MultiReader(readers ...Reader) Reader { - return &multiReader{readers} + r := make([]Reader, len(readers)) + copy(r, readers) + return &multiReader{r} } type multiWriter struct { @@ -53,5 +55,7 @@ func (t *multiWriter) Write(p []byte) (n int, err error) { // MultiWriter creates a writer that duplicates its writes to all the // provided writers, similar to the Unix tee(1) command. func MultiWriter(writers ...Writer) Writer { - return &multiWriter{writers} + w := make([]Writer, len(writers)) + copy(w, writers) + return &multiWriter{w} } diff --git a/libgo/go/io/multi_test.go b/libgo/go/io/multi_test.go index eb717f7..56c6769 100644 --- a/libgo/go/io/multi_test.go +++ b/libgo/go/io/multi_test.go @@ -9,6 +9,7 @@ import ( "crypto/sha1" "fmt" . "io" + "io/ioutil" "strings" "testing" ) @@ -86,3 +87,29 @@ func TestMultiWriter(t *testing.T) { t.Errorf("expected %q; got %q", sourceString, sink.String()) } } + +// Test that MultiReader copies the input slice and is insulated from future modification. +func TestMultiReaderCopy(t *testing.T) { + slice := []Reader{strings.NewReader("hello world")} + r := MultiReader(slice...) + slice[0] = nil + data, err := ioutil.ReadAll(r) + if err != nil || string(data) != "hello world" { + t.Errorf("ReadAll() = %q, %v, want %q, nil", data, err, "hello world") + } +} + +// Test that MultiWriter copies the input slice and is insulated from future modification. +func TestMultiWriterCopy(t *testing.T) { + var buf bytes.Buffer + slice := []Writer{&buf} + w := MultiWriter(slice...) + slice[0] = nil + n, err := w.Write([]byte("hello world")) + if err != nil || n != 11 { + t.Errorf("Write(`hello world`) = %d, %v, want 11, nil", n, err) + } + if buf.String() != "hello world" { + t.Errorf("buf.String() = %q, want %q", buf.String(), "hello world") + } +} |