aboutsummaryrefslogtreecommitdiff
path: root/libcpp
diff options
context:
space:
mode:
authorLewis Hyatt <lhyatt@gmail.com>2023-11-27 12:08:41 -0500
committerLewis Hyatt <lhyatt@gmail.com>2023-11-27 21:19:31 -0500
commitce52f1f7074d96c4d9ce63b1169c11087757e926 (patch)
treee182db7b9aa9e582133eea8b56f4a5a1e8b72452 /libcpp
parent9c16ca93641ad460a576a9ed7daf2aadf596193c (diff)
downloadgcc-ce52f1f7074d96c4d9ce63b1169c11087757e926.zip
gcc-ce52f1f7074d96c4d9ce63b1169c11087757e926.tar.gz
gcc-ce52f1f7074d96c4d9ce63b1169c11087757e926.tar.bz2
libcpp: Fix unsigned promotion for unevaluated divide by zero [PR112701]
When libcpp encounters a divide by zero while processing a constant expression "x/y", it returns "x" as a fallback. The value of the fallback is not normally important, since an error will be generated anyway, but if the expression appears in an unevaluated context, such as "0 ? 0/0u : -1", then there will be no error, and the fallback value will be meaningful to the extent that it may cause promotion from signed to unsigned of an operand encountered later. As the PR notes, libcpp does not do the unsigned promotion correctly in this case; fix it by making the fallback return value unsigned as necessary. libcpp/ChangeLog: PR preprocessor/112701 * expr.cc (num_div_op): Set unsignedp appropriately when returning a stub value for divide by 0. gcc/testsuite/ChangeLog: PR preprocessor/112701 * gcc.dg/cpp/expr.c: Add additional tests to cover divide by 0 in an unevaluated context, where the unsignedness still matters.
Diffstat (limited to 'libcpp')
-rw-r--r--libcpp/expr.cc1
1 files changed, 1 insertions, 0 deletions
diff --git a/libcpp/expr.cc b/libcpp/expr.cc
index 825d2c2..4f4a972 100644
--- a/libcpp/expr.cc
+++ b/libcpp/expr.cc
@@ -2216,6 +2216,7 @@ num_div_op (cpp_reader *pfile, cpp_num lhs, cpp_num rhs, enum cpp_ttype op,
if (!pfile->state.skip_eval)
cpp_error_with_line (pfile, CPP_DL_ERROR, location, 0,
"division by zero in #if");
+ lhs.unsignedp = unsignedp;
return lhs;
}