diff options
author | Andrew MacLeod <amacleod@redhat.com> | 2023-01-16 15:02:51 -0500 |
---|---|---|
committer | Andrew MacLeod <amacleod@redhat.com> | 2023-01-27 09:32:42 -0500 |
commit | f884c133dde519b4d8fc89f2f151711d1b0eb368 (patch) | |
tree | 632798a395c88d7716eb1014daf93ae61afce005 /gcc | |
parent | ec5e99e95954fd629283a9c9572193dd95471fea (diff) | |
download | gcc-f884c133dde519b4d8fc89f2f151711d1b0eb368.zip gcc-f884c133dde519b4d8fc89f2f151711d1b0eb368.tar.gz gcc-f884c133dde519b4d8fc89f2f151711d1b0eb368.tar.bz2 |
Correctly detect shifts out of range
get_shift_range was incorrectly communicating that it couldn't calculate
a range when the shift values was always out fo range. Fix this and
alwasy return [0, 0] when the shift value is always out of range.
PR tree-optimization/108306
gcc/
* range-op.cc (operator_lshift::fold_range): Return [0, 0] not
varying for shifts that are always out of void range.
(operator_rshift::fold_range): Return [0, 0] not
varying for shifts that are always out of void range.
gcc/testsuite/
* gcc.dg/pr108306.c: New.
Diffstat (limited to 'gcc')
-rw-r--r-- | gcc/range-op.cc | 4 | ||||
-rw-r--r-- | gcc/testsuite/gcc.dg/pr108306.c | 29 |
2 files changed, 31 insertions, 2 deletions
diff --git a/gcc/range-op.cc b/gcc/range-op.cc index ec75e07..6e5754e 100644 --- a/gcc/range-op.cc +++ b/gcc/range-op.cc @@ -2166,7 +2166,7 @@ operator_lshift::fold_range (irange &r, tree type, if (op2.undefined_p ()) r.set_undefined (); else - r.set_varying (type); + r.set_zero (type); return true; } @@ -2440,7 +2440,7 @@ operator_rshift::fold_range (irange &r, tree type, if (op2.undefined_p ()) r.set_undefined (); else - r.set_varying (type); + r.set_zero (type); return true; } diff --git a/gcc/testsuite/gcc.dg/pr108306.c b/gcc/testsuite/gcc.dg/pr108306.c new file mode 100644 index 0000000..1044c64 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr108306.c @@ -0,0 +1,29 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -fno-strict-overflow -fsanitize=shift -Warray-bounds" } */ + +enum psi_task_count { + NR_IOWAIT, + NR_PSI_TASK_COUNTS = 4, +}; + +unsigned int tasks[NR_PSI_TASK_COUNTS]; + +static void psi_group_change(unsigned int set) +{ + unsigned int t; + unsigned int state_mask = 0; + + for (t = 0; set; set &= ~(1 << t), t++) + if (set & (1 << t)) + tasks[t]++; +} + +void psi_task_switch(int sleep) +{ + int set = 0; + + if (sleep) + set |= (1 << NR_IOWAIT); + + psi_group_change(set); +} |