diff options
| author | Richard Biener <rguenther@suse.de> | 2024-01-23 09:51:00 +0100 |
|---|---|---|
| committer | Richard Biener <rguenther@suse.de> | 2024-01-23 11:15:29 +0100 |
| commit | e2f3057fc911f9f55986b3de237b0155c0e09fe8 (patch) | |
| tree | 48db71546280e6062a82bcd324225d1df1e1407d /gcc | |
| parent | affef534b0335592336c82918f15242576e2ab8f (diff) | |
| download | gcc-e2f3057fc911f9f55986b3de237b0155c0e09fe8.zip gcc-e2f3057fc911f9f55986b3de237b0155c0e09fe8.tar.gz gcc-e2f3057fc911f9f55986b3de237b0155c0e09fe8.tar.bz2 | |
debug/107058 - gracefully handle unexpected DIE contexts
While the bug is persisting that LTO streaming picks up a CONST_DECL
from an attribute argument on a VAR_DECL which with -fdebug-type-section
refers to a DIE in a type unit we can handle this gracefully, at least
with -fno-checking. Do so. The C++ frontend nevetheless should resolve
the CONST_DECL attribute argument to a constant.
PR debug/107058
* dwarf2out.cc (dwarf2out_die_ref_for_decl): Gracefully
handle unexpected but bogus DIE contexts when not checking
enabled.
* c-c++-common/pr107058.c: New testcase.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/dwarf2out.cc | 15 | ||||
| -rw-r--r-- | gcc/testsuite/c-c++-common/pr107058.c | 7 |
2 files changed, 18 insertions, 4 deletions
diff --git a/gcc/dwarf2out.cc b/gcc/dwarf2out.cc index 0b8a300..2b72321 100644 --- a/gcc/dwarf2out.cc +++ b/gcc/dwarf2out.cc @@ -6061,10 +6061,17 @@ dwarf2out_die_ref_for_decl (tree decl, const char **sym, die = die->die_parent; /* For the containing CU DIE we compute a die_symbol in compute_comp_unit_symbol. */ - gcc_assert (die->die_tag == DW_TAG_compile_unit - && die->die_id.die_symbol != NULL); - *sym = die->die_id.die_symbol; - return true; + if (die->die_tag == DW_TAG_compile_unit) + { + gcc_assert (die->die_id.die_symbol != NULL); + *sym = die->die_id.die_symbol; + return true; + } + /* While we can gracefully handle running into say a type unit + we don't really want and consider this a bug. */ + if (flag_checking) + gcc_unreachable (); + return false; } /* Add a reference of kind ATTR_KIND to a DIE at SYMBOL + OFFSET to DIE. */ diff --git a/gcc/testsuite/c-c++-common/pr107058.c b/gcc/testsuite/c-c++-common/pr107058.c new file mode 100644 index 0000000..5e625d6 --- /dev/null +++ b/gcc/testsuite/c-c++-common/pr107058.c @@ -0,0 +1,7 @@ +/* { dg-do compile } */ +/* { dg-require-effective-target lto } */ +/* { dg-options "-g -fdebug-types-section -flto -fno-checking" } */ + +/* We should handle the C++ FE issue gracefully with -fno-checking. */ + +#include "pr50459.c" |