diff options
| author | Richard Biener <rguenther@suse.de> | 2019-08-21 11:45:34 +0000 |
|---|---|---|
| committer | Richard Biener <rguenth@gcc.gnu.org> | 2019-08-21 11:45:34 +0000 |
| commit | d6dea10acfd9d775f260a2e7c319bb1ee64c0af0 (patch) | |
| tree | 4643749b529ef1dd3d1f4012fc5e77f628c9ea32 /gcc | |
| parent | 8bb2ee59398df615bf4b7c8fa6db2944485e4204 (diff) | |
| download | gcc-d6dea10acfd9d775f260a2e7c319bb1ee64c0af0.zip gcc-d6dea10acfd9d775f260a2e7c319bb1ee64c0af0.tar.gz gcc-d6dea10acfd9d775f260a2e7c319bb1ee64c0af0.tar.bz2 | |
re PR tree-optimization/91482 (__builtin_assume_aligned should not break write combining)
2019-08-21 Richard Biener <rguenther@suse.de>
PR tree-optimization/91482
* tree-ssa-ccp.c (ccp_folder::fold_stmt): Remove useless
BUILT_IN_ASSUME_ALIGNED calls.
* gcc.dg/tree-ssa/pr91482.c: New testcase.
From-SVN: r274796
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/tree-ssa/pr91482.c | 13 | ||||
| -rw-r--r-- | gcc/tree-ssa-ccp.c | 26 |
4 files changed, 50 insertions, 0 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index c17d0e1..7550e42 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,5 +1,11 @@ 2019-08-21 Richard Biener <rguenther@suse.de> + PR tree-optimization/91482 + * tree-ssa-ccp.c (ccp_folder::fold_stmt): Remove useless + BUILT_IN_ASSUME_ALIGNED calls. + +2019-08-21 Richard Biener <rguenther@suse.de> + PR target/91498 PR target/91503 * config/i386/i386-features.c diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 0bd6133..e8d22d1 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2019-08-21 Richard Biener <rguenther@suse.de> + + PR tree-optimization/91482 + * gcc.dg/tree-ssa/pr91482.c: New testcase. + 2019-08-21 Eric Botcazou <ebotcazou@adacore.com> * c-c++-common/dump-ada-spec-15.c: New test. diff --git a/gcc/testsuite/gcc.dg/tree-ssa/pr91482.c b/gcc/testsuite/gcc.dg/tree-ssa/pr91482.c new file mode 100644 index 0000000..7d6a724 --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/pr91482.c @@ -0,0 +1,13 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -fdump-tree-ccp1 -fdump-tree-store-merging" } */ + +void write64 (void *p) +{ + unsigned *p1 = (unsigned *) __builtin_assume_aligned (p, 8); + *p1++ = 0; + unsigned *p2 = (unsigned *) __builtin_assume_aligned (p1, 4); + *p2++ = 1; +} + +/* { dg-final { scan-tree-dump-times "__builtin_assume_aligned" 1 "ccp1" } } */ +/* { dg-final { scan-tree-dump "New sequence of 1 stores to replace old one of 2 stores" "store-merging" { target lp64 } } } */ diff --git a/gcc/tree-ssa-ccp.c b/gcc/tree-ssa-ccp.c index 458b218..5af3810 100644 --- a/gcc/tree-ssa-ccp.c +++ b/gcc/tree-ssa-ccp.c @@ -2315,6 +2315,32 @@ ccp_folder::fold_stmt (gimple_stmt_iterator *gsi) } } + /* If there's no extra info from an assume_aligned call, + drop it so it doesn't act as otherwise useless dataflow + barrier. */ + if (gimple_call_builtin_p (stmt, BUILT_IN_ASSUME_ALIGNED)) + { + tree ptr = gimple_call_arg (stmt, 0); + ccp_prop_value_t ptrval = get_value_for_expr (ptr, true); + if (ptrval.lattice_val == CONSTANT + && TREE_CODE (ptrval.value) == INTEGER_CST + && ptrval.mask != 0) + { + ccp_prop_value_t val + = bit_value_assume_aligned (stmt, NULL_TREE, ptrval, false); + unsigned int ptralign = least_bit_hwi (ptrval.mask.to_uhwi ()); + unsigned int align = least_bit_hwi (val.mask.to_uhwi ()); + if (ptralign == align + && ((TREE_INT_CST_LOW (ptrval.value) & (align - 1)) + == (TREE_INT_CST_LOW (val.value) & (align - 1)))) + { + bool res = update_call_from_tree (gsi, ptr); + gcc_assert (res); + return true; + } + } + } + /* Propagate into the call arguments. Compared to replace_uses_in this can use the argument slot types for type verification instead of the current argument type. We also can safely |