diff options
| author | Richard Sandiford <richard.sandiford@arm.com> | 2019-12-27 16:54:54 +0000 |
|---|---|---|
| committer | Richard Sandiford <rsandifo@gcc.gnu.org> | 2019-12-27 16:54:54 +0000 |
| commit | cd8aa0d1a5e9547cf3d47ab3bd53f63ec3920b36 (patch) | |
| tree | 8c26dff98ee27b49a1359fffaca1f64545c8327f /gcc | |
| parent | 049e64f8f19552ec75b6796223a8961038c24fcd (diff) | |
| download | gcc-cd8aa0d1a5e9547cf3d47ab3bd53f63ec3920b36.zip gcc-cd8aa0d1a5e9547cf3d47ab3bd53f63ec3920b36.tar.gz gcc-cd8aa0d1a5e9547cf3d47ab3bd53f63ec3920b36.tar.bz2 | |
Add missing target check for fully-masked fold-left reductions
The fold-left reduction code has a (rarely-used) fallback that handles
cases in which the loop is fully-masked and the target has no native
support for the reduction. The fallback includea a VEC_COND_EXPR
between the reduction vector and a safe value, so we should check
whether that VEC_COND_EXPR is supported.
2019-12-27 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* tree-vect-loop.c (vectorizable_reduction): Check whether the
target supports the required VEC_COND_EXPR operation before
allowing the fallback handling of masked fold-left reductions.
gcc/testsuite/
* gcc.target/aarch64/sve/mixed_size_10.c: New test.
From-SVN: r279742
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 4 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.target/aarch64/sve/mixed_size_10.c | 13 | ||||
| -rw-r--r-- | gcc/tree-vect-loop.c | 12 |
4 files changed, 35 insertions, 0 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 525a8f0..e30f6bb 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2019-12-27 Richard Sandiford <richard.sandiford@arm.com> + + * tree-vect-loop.c (vectorizable_reduction): Check whether the + target supports the required VEC_COND_EXPR operation before + allowing the fallback handling of masked fold-left reductions. + 2019-12-24 Jiufu Guo <guojiufu@linux.ibm.com> * config/rs6000/rs6000.c (rs6000_option_override_internal): Enable diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 0db2e22..d47dd3b 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2019-12-27 Richard Sandiford <richard.sandiford@arm.com> + + * gcc.target/aarch64/sve/mixed_size_10.c: New test. + 2019-12-26 Jakub Jelinek <jakub@redhat.com> PR c++/92438 diff --git a/gcc/testsuite/gcc.target/aarch64/sve/mixed_size_10.c b/gcc/testsuite/gcc.target/aarch64/sve/mixed_size_10.c new file mode 100644 index 0000000..bf22428 --- /dev/null +++ b/gcc/testsuite/gcc.target/aarch64/sve/mixed_size_10.c @@ -0,0 +1,13 @@ +/* { dg-options "-O3 -msve-vector-bits=256 -fno-tree-loop-distribution" } */ + +float +f (float *restrict x, double *restrict y) +{ + float res = 0.0; + for (int i = 0; i < 100; ++i) + { + res += x[i]; + y[i] += y[i - 4] * 11; + } + return res; +} diff --git a/gcc/tree-vect-loop.c b/gcc/tree-vect-loop.c index 68699f2..9b0cbcc 100644 --- a/gcc/tree-vect-loop.c +++ b/gcc/tree-vect-loop.c @@ -6718,6 +6718,18 @@ vectorizable_reduction (stmt_vec_info stmt_info, slp_tree slp_node, " conditional operation is available.\n"); LOOP_VINFO_CAN_FULLY_MASK_P (loop_vinfo) = false; } + else if (reduction_type == FOLD_LEFT_REDUCTION + && reduc_fn == IFN_LAST + && !expand_vec_cond_expr_p (vectype_in, + truth_type_for (vectype_in), + SSA_NAME)) + { + if (dump_enabled_p ()) + dump_printf_loc (MSG_MISSED_OPTIMIZATION, vect_location, + "can't use a fully-masked loop because no" + " conditional operation is available.\n"); + LOOP_VINFO_CAN_FULLY_MASK_P (loop_vinfo) = false; + } else vect_record_loop_mask (loop_vinfo, masks, ncopies * vec_num, vectype_in, NULL); |