diff options
| author | H.J. Lu <hongjiu.lu@intel.com> | 2018-01-11 20:44:46 +0000 |
|---|---|---|
| committer | H.J. Lu <hjl@gcc.gnu.org> | 2018-01-11 12:44:46 -0800 |
| commit | c7a61831d6ecec501acf0da0a227bd954e1d8922 (patch) | |
| tree | 5ad9cd96eee55b9a06e104696bd1e13e64b07498 /gcc | |
| parent | 278e902c24fd2ccbfe7c1ac2b0c4ef62a55696fc (diff) | |
| download | gcc-c7a61831d6ecec501acf0da0a227bd954e1d8922.zip gcc-c7a61831d6ecec501acf0da0a227bd954e1d8922.tar.gz gcc-c7a61831d6ecec501acf0da0a227bd954e1d8922.tar.bz2 | |
i386: Align stack frame if argument is passed on stack
When a function call is removed, it may become a leaf function. But if
argument may be passed on stack, we need to align the stack frame when
there is no tail call.
Tested on Linux/i686 and Linux/x86-64.
gcc/
PR target/83330
* config/i386/i386.c (ix86_compute_frame_layout): Align stack
frame if argument is passed on stack.
gcc/testsuite/
PR target/83330
* gcc.target/i386/pr83330.c: New test.
From-SVN: r256555
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/config/i386/i386.c | 7 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.target/i386/pr83330.c | 29 |
4 files changed, 46 insertions, 1 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index e676fec..2b939fb 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2018-01-11 H.J. Lu <hongjiu.lu@intel.com> + + PR target/83330 + * config/i386/i386.c (ix86_compute_frame_layout): Align stack + frame if argument is passed on stack. + 2018-01-11 Jakub Jelinek <jakub@redhat.com> PR target/82682 diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index 5e17b69..d6ff096 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -11339,11 +11339,16 @@ ix86_compute_frame_layout (void) offset += frame->va_arg_size; } - /* Align start of frame for local function. */ + /* Align start of frame for local function. When a function call + is removed, it may become a leaf function. But if argument may + be passed on stack, we need to align the stack when there is no + tail call. */ if (m->call_ms2sysv || frame->va_arg_size != 0 || size != 0 || !crtl->is_leaf + || (!crtl->tail_call_emit + && cfun->machine->outgoing_args_on_stack) || cfun->calls_alloca || ix86_current_function_calls_tls_descriptor) offset = ROUND_UP (offset, stack_alignment_needed); diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index b44ad56..31ed14c 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2018-01-11 H.J. Lu <hongjiu.lu@intel.com> + + PR target/83330 + * gcc.target/i386/pr83330.c: New test. + 2018-01-11 Steven G. Kargl <kargl@gcc.gnu.org> PR fortran/79383 diff --git a/gcc/testsuite/gcc.target/i386/pr83330.c b/gcc/testsuite/gcc.target/i386/pr83330.c new file mode 100644 index 0000000..8a63fbd --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr83330.c @@ -0,0 +1,29 @@ +/* { dg-do run { target int128 } } */ +/* { dg-options "-O2 -fno-tree-dce -mno-push-args" } */ + +typedef unsigned long long u64; +typedef unsigned __int128 u128; + +u64 v; +u64 g; + +u64 __attribute__ ((noinline, noclone)) +bar (u128 d, u64 e, u64 f, u64 g, u128 h) +{ + (void)d, (void)e, (void)f, (void)g, (void)h; + return 0; +} + +static u64 __attribute__ ((noipa)) +foo (void) +{ + (void)(v - bar (0, 0, 0, 0, 0)); + return g; +} + +int +main (void) +{ + (void)foo (); + return 0; +} |