diff options
| author | Tobias Burnus <tburnus@baylibre.com> | 2025-03-25 15:02:54 +0100 |
|---|---|---|
| committer | Tobias Burnus <tburnus@baylibre.com> | 2025-03-25 15:02:54 +0100 |
| commit | c6279fffdbf8e13e46932eb8e100cfc579d06f2c (patch) | |
| tree | 4cf761402194b88bc3f8c47fdef46ace1528989d /gcc | |
| parent | 927cfea902c330092848bd7a228b714b07d08f6b (diff) | |
| download | gcc-c6279fffdbf8e13e46932eb8e100cfc579d06f2c.zip gcc-c6279fffdbf8e13e46932eb8e100cfc579d06f2c.tar.gz gcc-c6279fffdbf8e13e46932eb8e100cfc579d06f2c.tar.bz2 | |
omp-general.cc: Remove 'if' around call to always 'true' returning function [PR118627]
Before omp_parse_access_method and omp_parse_access_methods unconditionally
returned true, now they are void functions.
Accordingly, calls had to be updated by removing the 'if' around the call;
this also fixes Clang's -Wsometimes-uninitialized warning when compiling
omp-general.cc as one variable remained uninitialized for a never occurring
false.
gcc/ChangeLog:
PR middle-end/118627
* omp-general.cc (omp_parse_access_method): Change to return void.
(omp_parse_access_methods): Return void; remove 'if' around a
function call.
(omp_parse_expr): Remove 'if' around a function call.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/omp-general.cc | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/gcc/omp-general.cc b/gcc/omp-general.cc index 0a2dd6b..0b7c3b9 100644 --- a/gcc/omp-general.cc +++ b/gcc/omp-general.cc @@ -4185,7 +4185,7 @@ omp_parse_pointer (tree *expr0, bool *has_offset) return false; } -static bool +static void omp_parse_access_method (tree *expr0, enum access_method_kinds *kind) { tree expr = *expr0; @@ -4216,18 +4216,17 @@ omp_parse_access_method (tree *expr0, enum access_method_kinds *kind) STRIP_NOPS (expr); *expr0 = expr; - return true; } -static bool +static void omp_parse_access_methods (vec<omp_addr_token *> &addr_tokens, tree *expr0) { tree expr = *expr0; enum access_method_kinds kind; tree am_expr; - if (omp_parse_access_method (&expr, &kind)) - am_expr = expr; + omp_parse_access_method (&expr, &kind); + am_expr = expr; if (TREE_CODE (expr) == INDIRECT_REF || TREE_CODE (expr) == MEM_REF @@ -4237,7 +4236,6 @@ omp_parse_access_methods (vec<omp_addr_token *> &addr_tokens, tree *expr0) addr_tokens.safe_push (new omp_addr_token (kind, am_expr)); *expr0 = expr; - return true; } static bool omp_parse_structured_expr (vec<omp_addr_token *> &, tree *); @@ -4355,8 +4353,7 @@ omp_parse_expr (vec<omp_addr_token *> &addr_tokens, tree expr) using namespace omp_addr_tokenizer; auto_vec<omp_addr_token *> expr_access_tokens; - if (!omp_parse_access_methods (expr_access_tokens, &expr)) - return false; + omp_parse_access_methods (expr_access_tokens, &expr); if (omp_parse_structured_expr (addr_tokens, &expr)) ; |