diff options
| author | Eric Botcazou <ebotcazou@adacore.com> | 2008-05-05 19:44:55 +0000 |
|---|---|---|
| committer | Eric Botcazou <ebotcazou@gcc.gnu.org> | 2008-05-05 19:44:55 +0000 |
| commit | bba74577c534f2d6567d8f6d5813d63e271f1026 (patch) | |
| tree | 57dcad53dac8fae566e8f3a996b0c2641c92d6ea /gcc | |
| parent | 2368848178cfe3eb1391285b57c2950aeac22507 (diff) | |
| download | gcc-bba74577c534f2d6567d8f6d5813d63e271f1026.zip gcc-bba74577c534f2d6567d8f6d5813d63e271f1026.tar.gz gcc-bba74577c534f2d6567d8f6d5813d63e271f1026.tar.bz2 | |
* decl.c (maybe_pad_type): Add ??? comment.
From-SVN: r134953
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ada/ChangeLog | 4 | ||||
| -rw-r--r-- | gcc/ada/decl.c | 8 |
2 files changed, 11 insertions, 1 deletions
diff --git a/gcc/ada/ChangeLog b/gcc/ada/ChangeLog index 28cf5dc..ae31fb4 100644 --- a/gcc/ada/ChangeLog +++ b/gcc/ada/ChangeLog @@ -1,3 +1,7 @@ +2008-05-05 Eric Botcazou <ebotcazou@adacore.com> + + * decl.c (maybe_pad_type): Add ??? comment. + 2008-05-03 Eric Botcazou <ebotcazou@adacore.com> * decl.c (components_to_record): Zero the alignment of the qualified diff --git a/gcc/ada/decl.c b/gcc/ada/decl.c index 68ea42b..6e14492 100644 --- a/gcc/ada/decl.c +++ b/gcc/ada/decl.c @@ -5671,7 +5671,13 @@ maybe_pad_type (tree type, tree size, unsigned int align, integral mode, which will be much more efficient. There is no point in doing so if a size is specified unless it is also a small constant size and it is incorrect to do so if we cannot guarantee that the mode - will be naturally aligned since the field must always be addressable. */ + will be naturally aligned since the field must always be addressable. + + ??? This might not always be a win when done for a stand-alone object: + since the nominal and the effective type of the object will now have + different modes, a VIEW_CONVERT_EXPR will be required for converting + between them and it might be hard to overcome afterwards, including + at the RTL level when the stand-alone object is accessed as a whole. */ if (align != 0 && TREE_CODE (type) == RECORD_TYPE && TYPE_MODE (type) == BLKmode |