diff options
| author | Richard Henderson <rth@redhat.com> | 2014-01-15 13:41:03 -0800 |
|---|---|---|
| committer | Richard Henderson <rth@gcc.gnu.org> | 2014-01-15 13:41:03 -0800 |
| commit | af6e846774d7ed8841ce700b28dc89b02291280d (patch) | |
| tree | d1d3786b095e17f4905aa5aaa2fd19078f41d1a5 /gcc | |
| parent | 4583fada2d37b41c5681b9f381f9251c1a5356dc (diff) | |
| download | gcc-af6e846774d7ed8841ce700b28dc89b02291280d.zip gcc-af6e846774d7ed8841ce700b28dc89b02291280d.tar.gz gcc-af6e846774d7ed8841ce700b28dc89b02291280d.tar.bz2 | |
re PR debug/54694 (internal compiler error: in dwarf2out_frame_debug_expr, at dwarf2out.c:2387)
PR debug/54694
Diagnose frame_pointer_required vs fixed hfp
From-SVN: r206647
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ChangeLog | 8 | ||||
| -rw-r--r-- | gcc/ira.c | 12 | ||||
| -rw-r--r-- | gcc/reginfo.c | 2 | ||||
| -rw-r--r-- | gcc/rtl.h | 2 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.target/i386/pr54694.c | 11 |
5 files changed, 34 insertions, 1 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index c93bf23..075582a 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,11 @@ +2014-01-15 Richard Henderson <rth@redhat.com> + + PR debug/54694 + * reginfo.c (global_regs_decl): Globalize. + * rtl.h (global_regs_decl): Declare. + * ira.c (do_reload): Diagnose frame_pointer_needed and it + reserved via global_regs. + 2014-01-15 Teresa Johnson <tejohnson@google.com> * tree-ssa-sccvn.c (visit_reference_op_call): Handle NULL vdef. @@ -5532,6 +5532,18 @@ do_reload (void) if (need_dce && optimize) run_fast_dce (); + /* Diagnose uses of the hard frame pointer when it is used as a global + register. Often we can get away with letting the user appropriate + the frame pointer, but we should let them know when code generation + makes that impossible. */ + if (global_regs[HARD_FRAME_POINTER_REGNUM] && frame_pointer_needed) + { + tree decl = global_regs_decl[HARD_FRAME_POINTER_REGNUM]; + error_at (DECL_SOURCE_LOCATION (current_function_decl), + "frame pointer required, but reserved"); + inform (DECL_SOURCE_LOCATION (decl), "for %qD", decl); + } + timevar_pop (TV_IRA); } diff --git a/gcc/reginfo.c b/gcc/reginfo.c index efaa0cb..bdb980d 100644 --- a/gcc/reginfo.c +++ b/gcc/reginfo.c @@ -86,7 +86,7 @@ static const char initial_call_really_used_regs[] = CALL_REALLY_USED_REGISTERS; char global_regs[FIRST_PSEUDO_REGISTER]; /* Declaration for the global register. */ -static tree GTY(()) global_regs_decl[FIRST_PSEUDO_REGISTER]; +tree global_regs_decl[FIRST_PSEUDO_REGISTER]; /* Same information as REGS_INVALIDATED_BY_CALL but in regset form to be used in dataflow more conveniently. */ @@ -2795,6 +2795,8 @@ extern void _fatal_insn (const char *, const_rtx, const char *, int, const char #define fatal_insn_not_found(insn) \ _fatal_insn_not_found (insn, __FILE__, __LINE__, __FUNCTION__) +/* reginfo.c */ +extern tree GTY(()) global_regs_decl[FIRST_PSEUDO_REGISTER]; #endif /* ! GCC_RTL_H */ diff --git a/gcc/testsuite/gcc.target/i386/pr54694.c b/gcc/testsuite/gcc.target/i386/pr54694.c new file mode 100644 index 0000000..bcf82c2 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr54694.c @@ -0,0 +1,11 @@ +/* { dg-do compile } */ +/* { dg-options "-O" } */ + +register void *hfp __asm__("%ebp"); /* { dg-message "note: for" } */ + +extern void g(void *); + +void f(int x) /* { dg-error "frame pointer required" } */ +{ + g(__builtin_alloca(x)); +} |