diff options
| author | Filip Kastl <fkastl@suse.cz> | 2025-03-20 11:54:59 +0100 |
|---|---|---|
| committer | Filip Kastl <fkastl@suse.cz> | 2025-03-20 13:32:43 +0100 |
| commit | a1363f8dd8037d40e9fbf04c2ba8d6d3e7e5c269 (patch) | |
| tree | c579542fffc08671d316ff4aa8fe61b8739a6882 /gcc | |
| parent | 7cc40201a135112824e44edeeb29017151652402 (diff) | |
| download | gcc-a1363f8dd8037d40e9fbf04c2ba8d6d3e7e5c269.zip gcc-a1363f8dd8037d40e9fbf04c2ba8d6d3e7e5c269.tar.gz gcc-a1363f8dd8037d40e9fbf04c2ba8d6d3e7e5c269.tar.bz2 | |
gimple: sccopy: Don't increment i after vec::unordered_remove()
I increment the index variable in a loop even when I do
vec::unordered_remove() which causes the vector traversal to miss some
elements. Mikael notified me of this mistake I made in my last patch.
gcc/ChangeLog:
* gimple-ssa-sccopy.cc (scc_copy_prop::propagate): Don't
increment after vec::unordered_remove().
Reported-by: Mikael Morin <mikael@gcc.gnu.org>
Signed-off-by: Filip Kastl <fkastl@suse.cz>
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/gimple-ssa-sccopy.cc | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/gcc/gimple-ssa-sccopy.cc b/gcc/gimple-ssa-sccopy.cc index 298feb0..ee2a7fa 100644 --- a/gcc/gimple-ssa-sccopy.cc +++ b/gcc/gimple-ssa-sccopy.cc @@ -582,9 +582,11 @@ scc_copy_prop::propagate () get removed. That means parts of CFG get removed. Those may contain copy statements. For that reason we prune SCCs here. */ unsigned i; - for (i = 0; i < scc.length (); i++) + for (i = 0; i < scc.length ();) if (gimple_bb (scc[i]) == NULL) scc.unordered_remove (i); + else + i++; if (scc.is_empty ()) { scc.release (); |