diff options
| author | Mike Stump <mrs@apple.com> | 2006-07-12 13:12:08 +0000 |
|---|---|---|
| committer | Mike Stump <mrs@gcc.gnu.org> | 2006-07-12 13:12:08 +0000 |
| commit | 8b907df422779e4e8e8c45c108d977c438596a0a (patch) | |
| tree | 50c5349162dd02d3c472fa9ef829d8c3ee475883 /gcc | |
| parent | 4b641750827a22aa0335f52c8319808acf3f6217 (diff) | |
| download | gcc-8b907df422779e4e8e8c45c108d977c438596a0a.zip gcc-8b907df422779e4e8e8c45c108d977c438596a0a.tar.gz gcc-8b907df422779e4e8e8c45c108d977c438596a0a.tar.bz2 | |
re PR c/28280 (bogus "statement with no effect" warning with VLA and typeof)
PR c/28280
* c-parser.c (c_parser_typeof_specifier): Don't use
c_finish_expr_stmt, open code desired semantics instead.
From-SVN: r115369
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ChangeLog | 4 | ||||
| -rw-r--r-- | gcc/c-parser.c | 14 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/vla-9.c | 9 |
3 files changed, 26 insertions, 1 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index b2cca5c..e5e82e6 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,5 +1,9 @@ 2006-07-12 Mike Stump <mrs@apple.com> + PR c/28280 + * c-parser.c (c_parser_typeof_specifier): Don't use + c_finish_expr_stmt, open code desired semantics instead. + * protoize.c (edit_fn_definition): Add volatile to clean_text_p. 2006-07-10 Eric Christopher <echristo@apple.com> diff --git a/gcc/c-parser.c b/gcc/c-parser.c index 32d2c51..d591284 100644 --- a/gcc/c-parser.c +++ b/gcc/c-parser.c @@ -2164,7 +2164,19 @@ c_parser_typeof_specifier (c_parser *parser) is evaluated, this can be evaluated. For now, we avoid evaluation when the context might. */ if (!skip_evaluation && was_vm) - c_finish_expr_stmt (expr.value); + { + tree e = expr.value; + + /* If the expression is not of a type to which we cannot assign a line + number, wrap the thing in a no-op NOP_EXPR. */ + if (DECL_P (e) || CONSTANT_CLASS_P (e)) + e = build1 (NOP_EXPR, void_type_node, e); + + if (EXPR_P (e)) + SET_EXPR_LOCATION (e, input_location); + + add_stmt (e); + } pop_maybe_used (was_vm); } c_parser_skip_until_found (parser, CPP_CLOSE_PAREN, "expected %<)%>"); diff --git a/gcc/testsuite/gcc.dg/vla-9.c b/gcc/testsuite/gcc.dg/vla-9.c new file mode 100644 index 0000000..0b623b3 --- /dev/null +++ b/gcc/testsuite/gcc.dg/vla-9.c @@ -0,0 +1,9 @@ +/* { dg-do compile } */ +/* { dg-options "-std=c99 -pedantic-errors -W -Wall" } */ +/* PR c/28280 */ + +void f(__SIZE_TYPE__ d) +{ + typedef int t[d]; + t *g = (__typeof (g)) d; +} |