diff options
| author | Ian Lance Taylor <iant@google.com> | 2009-06-19 15:25:16 +0000 |
|---|---|---|
| committer | Ian Lance Taylor <ian@gcc.gnu.org> | 2009-06-19 15:25:16 +0000 |
| commit | 88eeff6f5a1347dc09de33c26a68648c4dea7f80 (patch) | |
| tree | fc52468ac72e4ed7eef097489864a842fdb17db4 /gcc | |
| parent | 28a876a42966c74582188b6c124c790f0b724535 (diff) | |
| download | gcc-88eeff6f5a1347dc09de33c26a68648c4dea7f80.zip gcc-88eeff6f5a1347dc09de33c26a68648c4dea7f80.tar.gz gcc-88eeff6f5a1347dc09de33c26a68648c4dea7f80.tar.bz2 | |
c-decl.c (grokdeclarator): If -Wc++-compat, warn about a global variable with an anonymous type.
./: * c-decl.c (grokdeclarator): If -Wc++-compat, warn about a global
variable with an anonymous type.
fortran/:
* cpp.c (struct gfc_cpp_option_data): Give this struct, used for
the global variable gfc_cpp_option, a name.
testsuite/:
* gcc.dg/Wcxx-compat-16.c: New testcase.
From-SVN: r148708
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/c-decl.c | 13 | ||||
| -rw-r--r-- | gcc/fortran/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/fortran/cpp.c | 2 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 4 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/Wcxx-compat-16.c | 12 |
6 files changed, 40 insertions, 1 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index c327984..37a3629 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2009-06-19 Ian Lance Taylor <iant@google.com> + + * c-decl.c (grokdeclarator): If -Wc++-compat, warn about a global + variable with an anonymous type. + 2009-06-19 Uros Bizjak <ubizjak@gmail.com> * see.c: Remove for real. diff --git a/gcc/c-decl.c b/gcc/c-decl.c index 4e48bac..57cbd28 100644 --- a/gcc/c-decl.c +++ b/gcc/c-decl.c @@ -5875,6 +5875,19 @@ grokdeclarator (const struct c_declarator *declarator, name of a variable. Thus, if it's known before this, die horribly. */ gcc_assert (!DECL_ASSEMBLER_NAME_SET_P (decl)); + if (warn_cxx_compat + && TREE_CODE (decl) == VAR_DECL + && TREE_PUBLIC (decl) + && TREE_STATIC (decl) + && (TREE_CODE (TREE_TYPE (decl)) == RECORD_TYPE + || TREE_CODE (TREE_TYPE (decl)) == UNION_TYPE + || TREE_CODE (TREE_TYPE (decl)) == ENUMERAL_TYPE) + && TYPE_NAME (TREE_TYPE (decl)) == NULL_TREE) + warning_at (DECL_SOURCE_LOCATION (decl), OPT_Wc___compat, + ("non-local variable %qD with anonymous type is " + "questionable in C++"), + decl); + return decl; } } diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog index d3d140b..136a0e5 100644 --- a/gcc/fortran/ChangeLog +++ b/gcc/fortran/ChangeLog @@ -1,3 +1,8 @@ +2009-06-19 Ian Lance Taylor <iant@google.com> + + * cpp.c (struct gfc_cpp_option_data): Give this struct, used for + the global variable gfc_cpp_option, a name. + 2009-06-19 Janus Weil <janus@gcc.gnu.org> PR fortran/40450 diff --git a/gcc/fortran/cpp.c b/gcc/fortran/cpp.c index 9187bed..ec8bb59 100644 --- a/gcc/fortran/cpp.c +++ b/gcc/fortran/cpp.c @@ -66,7 +66,7 @@ typedef struct gfc_cpp_macro_queue } gfc_cpp_macro_queue; static gfc_cpp_macro_queue *cpp_define_queue, *cpp_undefine_queue; -struct +struct gfc_cpp_option_data { /* Argument of -cpp, implied by SPEC; if NULL, preprocessing disabled. */ diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 918d198..b68dc7e 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2009-06-19 Ian Lance Taylor <iant@google.com> + + * gcc.dg/Wcxx-compat-16.c: New testcase. + 2009-06-19 Uros Bizjak <ubizjak@gmail.com> * gcc.dg/builtins-34.c: Add significand cases. diff --git a/gcc/testsuite/gcc.dg/Wcxx-compat-16.c b/gcc/testsuite/gcc.dg/Wcxx-compat-16.c new file mode 100644 index 0000000..51b503b --- /dev/null +++ b/gcc/testsuite/gcc.dg/Wcxx-compat-16.c @@ -0,0 +1,12 @@ +/* { dg-do compile } */ +/* { dg-options "-Wc++-compat" } */ + +struct { int f1; } g1; /* { dg-warning "C\[+\]\[+\]" } */ +static struct { int f2; } g2; +struct s { int f3; } g3; +union { int f4; } g4; /* { dg-warning "C\[+\]\[+\]" } */ +static union { int f5; } g5; +union u { int f6; } g6; +enum { A } g7; /* { dg-warning "C\[+\]\[+\]" } */ +static enum { B } g8; +enum E { C } g9; |