diff options
| author | Steve Kargl <kargl@gcc.gnu.org> | 2023-02-07 20:18:42 +0100 |
|---|---|---|
| committer | Harald Anlauf <anlauf@gmx.de> | 2023-02-08 19:02:21 +0100 |
| commit | 7e9f20f5517429cfaadec14d6b04705e59078565 (patch) | |
| tree | 1cfd49bec6d5cb5459b9e027b305f1bc9f27931a /gcc | |
| parent | 6ad1c1027628f094260037536f6b6fcdb63b5add (diff) | |
| download | gcc-7e9f20f5517429cfaadec14d6b04705e59078565.zip gcc-7e9f20f5517429cfaadec14d6b04705e59078565.tar.gz gcc-7e9f20f5517429cfaadec14d6b04705e59078565.tar.bz2 | |
Fortran: error handling of global entity appearing in COMMON block [PR103259]
gcc/fortran/ChangeLog:
PR fortran/103259
* resolve.cc (resolve_common_vars): Avoid NULL pointer dereference
when a symbol's location is not set.
gcc/testsuite/ChangeLog:
PR fortran/103259
* gfortran.dg/pr103259.f90: New test.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/fortran/resolve.cc | 12 | ||||
| -rw-r--r-- | gcc/testsuite/gfortran.dg/pr103259.f90 | 11 |
2 files changed, 20 insertions, 3 deletions
diff --git a/gcc/fortran/resolve.cc b/gcc/fortran/resolve.cc index 100b238..549916c 100644 --- a/gcc/fortran/resolve.cc +++ b/gcc/fortran/resolve.cc @@ -953,9 +953,15 @@ resolve_common_vars (gfc_common_head *common_block, bool named_common) { gsym = gfc_find_gsymbol (gfc_gsym_root, csym->name); if (gsym && (gsym->type == GSYM_MODULE || gsym->type == GSYM_PROGRAM)) - gfc_error_now ("Global entity %qs at %L cannot appear in a " - "COMMON block at %L", gsym->name, - &gsym->where, &csym->common_block->where); + { + if (csym->common_block) + gfc_error_now ("Global entity %qs at %L cannot appear in a " + "COMMON block at %L", gsym->name, + &gsym->where, &csym->common_block->where); + else + gfc_error_now ("Global entity %qs at %L cannot appear in a " + "COMMON block", gsym->name, &gsym->where); + } /* gfc_add_in_common may have been called before, but the reported errors have been ignored to continue parsing. diff --git a/gcc/testsuite/gfortran.dg/pr103259.f90 b/gcc/testsuite/gfortran.dg/pr103259.f90 new file mode 100644 index 0000000..f78ff26 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr103259.f90 @@ -0,0 +1,11 @@ +! { dg-do compile } +! PR fortran/103259 - ICE in resolve_common_vars +! Contributed by G.Steinmetz + +module m + integer :: p + common /c/ p +end +program p ! { dg-error "cannot appear in a COMMON block" } + use m ! { dg-error "is also the name of the current program unit" } +end |