diff options
| author | Bob Duff <duff@adacore.com> | 2023-10-18 09:54:06 -0400 |
|---|---|---|
| committer | Marc Poulhiès <poulhies@adacore.com> | 2023-11-07 10:15:05 +0100 |
| commit | 756e05d1565482e7b24f9cf51ffcfeced5a9d91c (patch) | |
| tree | 59bfc98e0a372bd11abe8c7656451f92a507cf84 /gcc | |
| parent | 09e5e68c07c8cf6e30af0f7553c2565bbbed49b4 (diff) | |
| download | gcc-756e05d1565482e7b24f9cf51ffcfeced5a9d91c.zip gcc-756e05d1565482e7b24f9cf51ffcfeced5a9d91c.tar.gz gcc-756e05d1565482e7b24f9cf51ffcfeced5a9d91c.tar.bz2 | |
ada: Compiler crash on early alignment clause
This patch fixes a bug: if "for T'Alignment use..." is followed
by "for T use (<enum rep>);" the compiler crashes. A workaround is
to move the alignment clause after the enumeration rep clause.
gcc/ada/
* sem_ch13.ads (Set_Enum_Esize): Do not set alignment.
* sem_ch13.adb (Set_Enum_Esize): Do not set alignment. Archaeology
seems to show that this line of code dates from when "Alignment =
0" meant "the Alignment is not known at compile time" and "the
Alignment is not yet known at compile time" as well as "the
Alignment is zero". In any case, it seems to be unnecessary, and
in this case harmful, because gigi would crash. Alignment_Clause
is set (because there is one), so gigi would query the Alignment,
but Alignment was destroyed.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ada/sem_ch13.adb | 2 | ||||
| -rw-r--r-- | gcc/ada/sem_ch13.ads | 3 |
2 files changed, 1 insertions, 4 deletions
diff --git a/gcc/ada/sem_ch13.adb b/gcc/ada/sem_ch13.adb index 5747ee9..302fab7 100644 --- a/gcc/ada/sem_ch13.adb +++ b/gcc/ada/sem_ch13.adb @@ -17381,8 +17381,6 @@ package body Sem_Ch13 is Sz : Unat; begin - Reinit_Alignment (T); - -- Find the minimum standard size (8,16,32,64,128) that fits Lo := Enumeration_Rep (Entity (Type_Low_Bound (T))); diff --git a/gcc/ada/sem_ch13.ads b/gcc/ada/sem_ch13.ads index 1386096..555d302 100644 --- a/gcc/ada/sem_ch13.ads +++ b/gcc/ada/sem_ch13.ads @@ -79,8 +79,7 @@ package Sem_Ch13 is procedure Set_Enum_Esize (T : Entity_Id); -- This routine sets the Esize field for an enumeration type T, based -- on the current representation information available for T. Note that - -- the setting of the RM_Size field is not affected. This routine also - -- initializes the alignment field to zero. + -- the setting of the RM_Size field is not affected. Unknown_Minimum_Size : constant Nonzero_Int := -1; |