diff options
author | Ilya Enkovich <ilya.enkovich@intel.com> | 2015-03-12 09:53:36 +0000 |
---|---|---|
committer | Ilya Enkovich <ienkovich@gcc.gnu.org> | 2015-03-12 09:53:36 +0000 |
commit | 58b387e61f3236b6c0c0eea54b92c4bf8f85e98d (patch) | |
tree | 8590e2e69903c6f16de8debdfaf054da8e7633dc /gcc | |
parent | 1b89b8f062f42c782ca528be2a8239019141947f (diff) | |
download | gcc-58b387e61f3236b6c0c0eea54b92c4bf8f85e98d.zip gcc-58b387e61f3236b6c0c0eea54b92c4bf8f85e98d.tar.gz gcc-58b387e61f3236b6c0c0eea54b92c4bf8f85e98d.tar.bz2 |
re PR target/65103 ([i386] GOTOFF relocation is not propagated into address expression)
gcc/
PR target/65103
* config/i386/i386.c (ix86_address_cost): Fix cost of a PIC
register.
gcc/testsuite/
PR target/65103
* gcc.target/i386/pr65103-1.c: New.
From-SVN: r221380
Diffstat (limited to 'gcc')
-rw-r--r-- | gcc/ChangeLog | 6 | ||||
-rw-r--r-- | gcc/config/i386/i386.c | 36 | ||||
-rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
-rw-r--r-- | gcc/testsuite/gcc.target/i386/pr65103-1.c | 19 |
4 files changed, 46 insertions, 20 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 3a91320..43d6717 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,5 +1,11 @@ 2015-03-12 Ilya Enkovich <ilya.enkovich@intel.com> + PR target/65103 + * config/i386/i386.c (ix86_address_cost): Fix cost of a PIC + register. + +2015-03-12 Ilya Enkovich <ilya.enkovich@intel.com> + PR target/65044 * toplev.c (process_options): Restrict Pointer Bounds Checker usage with Address Sanitizer. diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index ab8f03a..47deda7 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -12931,30 +12931,26 @@ ix86_address_cost (rtx x, machine_mode, addr_space_t, bool) if (parts.index && GET_CODE (parts.index) == SUBREG) parts.index = SUBREG_REG (parts.index); - /* Attempt to minimize number of registers in the address. */ - if ((parts.base - && (!REG_P (parts.base) || REGNO (parts.base) >= FIRST_PSEUDO_REGISTER)) - || (parts.index - && (!REG_P (parts.index) - || REGNO (parts.index) >= FIRST_PSEUDO_REGISTER))) - cost++; - - /* When address base or index is "pic_offset_table_rtx" we don't increase - address cost. When a memopt with "pic_offset_table_rtx" is not invariant - itself it most likely means that base or index is not invariant. - Therefore only "pic_offset_table_rtx" could be hoisted out, which is not - profitable for x86. */ + /* Attempt to minimize number of registers in the address by increasing + address cost for each used register. We don't increase address cost + for "pic_offset_table_rtx". When a memopt with "pic_offset_table_rtx" + is not invariant itself it most likely means that base or index is not + invariant. Therefore only "pic_offset_table_rtx" could be hoisted out, + which is not profitable for x86. */ if (parts.base - && (current_pass->type == GIMPLE_PASS - || (!pic_offset_table_rtx - || REGNO (pic_offset_table_rtx) != REGNO(parts.base))) && (!REG_P (parts.base) || REGNO (parts.base) >= FIRST_PSEUDO_REGISTER) - && parts.index && (current_pass->type == GIMPLE_PASS - || (!pic_offset_table_rtx - || REGNO (pic_offset_table_rtx) != REGNO(parts.index))) + || !pic_offset_table_rtx + || !REG_P (parts.base) + || REGNO (pic_offset_table_rtx) != REGNO (parts.base))) + cost++; + + if (parts.index && (!REG_P (parts.index) || REGNO (parts.index) >= FIRST_PSEUDO_REGISTER) - && parts.base != parts.index) + && (current_pass->type == GIMPLE_PASS + || !pic_offset_table_rtx + || !REG_P (parts.index) + || REGNO (pic_offset_table_rtx) != REGNO (parts.index))) cost++; /* AMD-K6 don't like addresses with ModR/M set to 00_xxx_100b, diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 485a3f8..4bd7f0e 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,5 +1,10 @@ 2015-03-12 Ilya Enkovich <ilya.enkovich@intel.com> + PR target/65103 + * gcc.target/i386/pr65103-1.c: New. + +2015-03-12 Ilya Enkovich <ilya.enkovich@intel.com> + PR target/65044 * gcc.target/i386/pr65044.c: New. diff --git a/gcc/testsuite/gcc.target/i386/pr65103-1.c b/gcc/testsuite/gcc.target/i386/pr65103-1.c new file mode 100644 index 0000000..4e3a7a3 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr65103-1.c @@ -0,0 +1,19 @@ +/* { dg-do compile { target ia32 } } */ +/* { dg-require-effective-target pie } */ +/* { dg-options "-O2 -fPIE" } */ +/* { dg-final { scan-assembler-not "GOTOFF," } } */ + +typedef struct S +{ + int a; + int sum; + int delta; +} S; + +S gs; +int global_opt (int max) +{ + while (gs.sum < max) + gs.sum += gs.delta; + return gs.a; +} |