diff options
| author | Alexandre Oliva <oliva@adacore.com> | 2021-12-29 04:10:46 -0300 |
|---|---|---|
| committer | Pierre-Marie de Rodat <derodat@adacore.com> | 2022-05-10 08:19:30 +0000 |
| commit | 3b3bd801520e707d113c0f81e028abae023c4d3a (patch) | |
| tree | 0f0f231dd2436103c1feda325aa43a39ddae2d14 /gcc | |
| parent | bf687b8085403b94209269e15491f286644ec10b (diff) | |
| download | gcc-3b3bd801520e707d113c0f81e028abae023c4d3a.zip gcc-3b3bd801520e707d113c0f81e028abae023c4d3a.tar.gz gcc-3b3bd801520e707d113c0f81e028abae023c4d3a.tar.bz2 | |
[Ada] Optimize nonstandard boolean validity checking
Validity checking of enumerations with nonstandard representation
starts by checking the value range, then calling _rep_to_pos to verify
that the value itself is valid. The value range check is thus
redundant and inefficient: the _rep_to_pos call is normally inlined
when optimizing for speed and the range check slows down the fast
path; it is unnecesary and undesirable when optimizing for size, and
just unnecessary when not optimizing. This patch thus drops the range
check for nonstandard boolean types.
gcc/ada/
* exp_attr.adb (Expand_N_Attribute_Reference) <Attribute_Valid>:
Drop redundant range check for nonstandard booleans.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ada/exp_attr.adb | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/gcc/ada/exp_attr.adb b/gcc/ada/exp_attr.adb index 7b36dae..cc04351 100644 --- a/gcc/ada/exp_attr.adb +++ b/gcc/ada/exp_attr.adb @@ -7281,7 +7281,11 @@ package body Exp_Attr is New_Occurrence_Of (Standard_False, Loc))), Right_Opnd => Make_Integer_Literal (Loc, 0)); - if Ptyp /= PBtyp + -- Skip the range test for boolean types, as it buys us + -- nothing. The function called above already fails for + -- values different from both True and False. + + if Ptyp /= PBtyp and then not Is_Boolean_Type (PBtyp) and then (Type_Low_Bound (Ptyp) /= Type_Low_Bound (PBtyp) or else |