diff options
| author | Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org> | 2018-05-15 04:44:33 +0000 |
|---|---|---|
| committer | Prathamesh Kulkarni <prathamesh3492@gcc.gnu.org> | 2018-05-15 04:44:33 +0000 |
| commit | 0fac5f2a7f15974deabf6432f4f510d0f4bcc6bc (patch) | |
| tree | 8f4a374e2fe65e6e08730920207a99968ad8fe0c /gcc | |
| parent | a25c2c79667effe27af171e91818fa757ffb0029 (diff) | |
| download | gcc-0fac5f2a7f15974deabf6432f4f510d0f4bcc6bc.zip gcc-0fac5f2a7f15974deabf6432f4f510d0f4bcc6bc.tar.gz gcc-0fac5f2a7f15974deabf6432f4f510d0f4bcc6bc.tar.bz2 | |
re PR ipa/85734 (--suggest-attribute=malloc misdiagnoses static functions)
2018-05-15 Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
PR ipa/85734
* ipa-pure-const.c (warn_function_malloc): Pass value of known_finite param
as true in call to suggest_attribute.
testsuite/
* gcc.dg/ipa/pr85734.c: New test.
From-SVN: r260249
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/ipa-pure-const.c | 2 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/ipa/pr85734.c | 19 |
4 files changed, 31 insertions, 1 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 9e54758..294a937 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2018-05-15 Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org> + + PR ipa/85734 + * ipa-pure-const.c (warn_function_malloc): Pass value of known_finite param + as true in call to suggest_attribute. + 2018-05-14 Segher Boessenkool <segher@kernel.crashing.org> * doc/invoke.texi (RS/6000 and PowerPC Options): Delete @itemx for diff --git a/gcc/ipa-pure-const.c b/gcc/ipa-pure-const.c index a80b684..7665358 100644 --- a/gcc/ipa-pure-const.c +++ b/gcc/ipa-pure-const.c @@ -249,7 +249,7 @@ warn_function_malloc (tree decl) static hash_set<tree> *warned_about; warned_about = suggest_attribute (OPT_Wsuggest_attribute_malloc, decl, - false, warned_about, "malloc"); + true, warned_about, "malloc"); } /* Emit suggestion about __attribute__((noreturn)) for DECL. */ diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 4a0b371..452e6a2 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2018-05-14 Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org> + + PR ipa/85734 + * gcc.dg/ipa/pr85734.c: New test. + 2018-05-14 Eric Botcazou <ebotcazou@adacore.com> PR target/85756 diff --git a/gcc/testsuite/gcc.dg/ipa/pr85734.c b/gcc/testsuite/gcc.dg/ipa/pr85734.c new file mode 100644 index 0000000..e5fa21f --- /dev/null +++ b/gcc/testsuite/gcc.dg/ipa/pr85734.c @@ -0,0 +1,19 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -Wsuggest-attribute=malloc" } */ + +__attribute__((noinline)) +static void *f1(__SIZE_TYPE__ sz) /* { dg-bogus "function might be candidate for attribute 'malloc'" } */ +{ + return __builtin_malloc (sz); +} + +__attribute__((noinline)) +static void *f2(__SIZE_TYPE__ sz) /* { dg-bogus "function might be candidate for attribute 'malloc'" } */ +{ + return f1 (sz); +} + +void *f3(__SIZE_TYPE__ sz) /* { dg-warning "function might be candidate for attribute 'malloc'" } */ +{ + return f2(sz); +} |