Remove unreachable returns

This removes unreachable return statements as diagnosed by
the -Wunreachable-code patch.  Some cases are more obviously
an improvement than others - in fact some may get you the idea
to replace them with gcc_unreachable () instead, leading to
cases of the 'Remove unreachable gcc_unreachable () at the end
of functions' patch.

2021-11-25  Richard Biener  <rguenther@suse.de>

	* vec.c (qsort_chk): Do not return the void return value
	from the noreturn qsort_chk_error.
	* ccmp.c (expand_ccmp_expr_1): Remove unreachable return.
	* df-scan.c (df_ref_equal_p): Likewise.
	* dwarf2out.c (is_base_type): Likewise.
	(add_const_value_attribute): Likewise.
	* fixed-value.c (fixed_arithmetic): Likewise.
	* gimple-fold.c (gimple_fold_builtin_fputs): Likewise.
	* gimple-ssa-strength-reduction.c (stmt_cost): Likewise.
	* graphite-isl-ast-to-gimple.c
	(gcc_expression_from_isl_expr_op): Likewise.
	(gcc_expression_from_isl_expression): Likewise.
	* ipa-fnsummary.c (will_be_nonconstant_expr_predicate):
	Likewise.
	* lto-streamer-in.c (lto_input_mode_table): Likewise.

gcc/c-family/
	* c-opts.c (c_common_post_options): Remove unreachable return.
	* c-pragma.c (handle_pragma_target): Likewise.
	(handle_pragma_optimize): Likewise.

gcc/c/
	* c-typeck.c (c_tree_equal): Remove unreachable return.
	* c-parser.c (get_matching_symbol): Likewise.

libgomp/
	* oacc-plugin.c (GOMP_PLUGIN_acc_default_dim): Remove unreachable
	return.

1 files changed, 5 insertions, 5 deletions

diff --git a/gcc/vec.c b/gcc/vec.c
index 6d767cc..bdbd1ad 100644
--- a/gcc/vec.c
+++ b/gcc/vec.c
@@ -229,23 +229,23 @@ qsort_chk (void *base, size_t n, size_t size, sort_r_cmp_fn *cmp, void *data)
 	if (CMP (i1, i2))
 	  break;
 	else if (CMP (i2, i1))
-	  return ERR2 (i1, i2);
+	  ERR2 (i1, i2);
       size_t lim1 = LIM (i2 - i1), lim2 = LIM (n - i2);
       /* Verify that other pairs within current span compare equal.  */
       for (i = i1 + 1; i + 1 < i2; i++)
 	for (j = i + 1; j < i1 + lim1; j++)
 	  if (CMP (i, j))
-	    return ERR3 (i, i1, j);
+	    ERR3 (i, i1, j);
 	  else if (CMP (j, i))
-	    return ERR2 (i, j);
+	    ERR2 (i, j);
       /* Verify that elements within this span compare less than
          elements beyond the span.  */
       for (i = i1; i < i2; i++)
 	for (j = i2; j < i2 + lim2; j++)
 	  if (CMP (i, j) >= 0)
-	    return ERR3 (i, i1, j);
+	    ERR3 (i, i1, j);
 	  else if (CMP (j, i) <= 0)
-	    return ERR2 (i, j);
+	    ERR2 (i, j);
     }
 #undef ERR3
 #undef ERR2