diff options
| author | Richard Biener <rguenther@suse.de> | 2025-02-03 09:55:50 +0100 |
|---|---|---|
| committer | Richard Biener <rguenth@gcc.gnu.org> | 2025-02-03 11:23:22 +0100 |
| commit | fbcbbfe2bf83eb8b1347144eeca37b06be5a8bb5 (patch) | |
| tree | 08b78236ed838b6e8c379f2b382edb30b198bb81 /gcc/tree-ssa-phiopt.cc | |
| parent | 75ab30f77f6d8a555aa78472b45a75a508544c68 (diff) | |
| download | gcc-fbcbbfe2bf83eb8b1347144eeca37b06be5a8bb5.zip gcc-fbcbbfe2bf83eb8b1347144eeca37b06be5a8bb5.tar.gz gcc-fbcbbfe2bf83eb8b1347144eeca37b06be5a8bb5.tar.bz2 | |
tree-optimization/118717 - store commoning vs. abnormals
When we sink common stores in cselim or the sink pass we have to
make sure to not introduce overlapping lifetimes for abnormals
used in the ref. The easiest is to avoid sinking stmts which
reference abnormals at all which is what the following does.
PR tree-optimization/118717
* tree-ssa-phiopt.cc (cond_if_else_store_replacement_1):
Do not common stores referencing abnormal SSA names.
* tree-ssa-sink.cc (sink_common_stores_to_bb): Likewise.
* gcc.dg/torture/pr118717.c: New testcase.
Diffstat (limited to 'gcc/tree-ssa-phiopt.cc')
| -rw-r--r-- | gcc/tree-ssa-phiopt.cc | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/gcc/tree-ssa-phiopt.cc b/gcc/tree-ssa-phiopt.cc index 64d3ba9..f67f52d 100644 --- a/gcc/tree-ssa-phiopt.cc +++ b/gcc/tree-ssa-phiopt.cc @@ -3646,7 +3646,9 @@ cond_if_else_store_replacement_1 (basic_block then_bb, basic_block else_bb, || else_assign == NULL || !gimple_assign_single_p (else_assign) || gimple_clobber_p (else_assign) - || gimple_has_volatile_ops (else_assign)) + || gimple_has_volatile_ops (else_assign) + || stmt_references_abnormal_ssa_name (then_assign) + || stmt_references_abnormal_ssa_name (else_assign)) return false; lhs = gimple_assign_lhs (then_assign); |