diff options
| author | Jan Hubicka <jh@suse.cz> | 2023-07-28 09:16:09 +0200 |
|---|---|---|
| committer | Jan Hubicka <jh@suse.cz> | 2023-07-28 09:16:09 +0200 |
| commit | b9d7140c80bd3c7355b8291bb46f0895dcd8c3cb (patch) | |
| tree | 985d7069f1df4f523a3e45627e455f8d30ac69b3 /gcc/tree-ssa-loop-split.cc | |
| parent | 54e54f77c1012ab53126314181c51eaee146ad5d (diff) | |
| download | gcc-b9d7140c80bd3c7355b8291bb46f0895dcd8c3cb.zip gcc-b9d7140c80bd3c7355b8291bb46f0895dcd8c3cb.tar.gz gcc-b9d7140c80bd3c7355b8291bb46f0895dcd8c3cb.tar.bz2 | |
loop-split improvements, part 1
while looking on profile misupdate on hmmer I noticed that loop splitting pass is not
able to handle the loop it has as an example it should apply on:
One transformation of loops like:
for (i = 0; i < 100; i++)
{
if (i < 50)
A;
else
B;
}
into:
for (i = 0; i < 50; i++)
{
A;
}
for (; i < 100; i++)
{
B;
}
The problem is that ivcanon turns the test into i != 100 and the pass
explicitly gives up on any loops ending with != test. It needs to know
the directoin of the induction variable in order to derive right conditions,
but that can be done also from step.
It turns out that there are no testcases for basic loop splitting. I will add
some with the profile update fix.
gcc/ChangeLog:
* tree-ssa-loop-split.cc (split_loop): Also support NE driven
loops when IV test is not overflowing.
gcc/testsuite/ChangeLog:
* gcc.dg/tree-ssa/ifc-12.c: Disable loop splitting.
* gcc.target/i386/avx2-gather-6.c: Likewise.
* gcc.target/i386/avx2-vect-aggressive.c: Likewise.
Diffstat (limited to 'gcc/tree-ssa-loop-split.cc')
| -rw-r--r-- | gcc/tree-ssa-loop-split.cc | 13 |
1 files changed, 10 insertions, 3 deletions
diff --git a/gcc/tree-ssa-loop-split.cc b/gcc/tree-ssa-loop-split.cc index b41b5e6..f441f3f 100644 --- a/gcc/tree-ssa-loop-split.cc +++ b/gcc/tree-ssa-loop-split.cc @@ -540,10 +540,17 @@ split_loop (class loop *loop1) || !empty_block_p (loop1->latch) || !easy_exit_values (loop1) || !number_of_iterations_exit (loop1, exit1, &niter, false, true) - || niter.cmp == ERROR_MARK - /* We can't yet handle loops controlled by a != predicate. */ - || niter.cmp == NE_EXPR) + || niter.cmp == ERROR_MARK) return false; + if (niter.cmp == NE_EXPR) + { + if (!niter.control.no_overflow) + return false; + if (tree_int_cst_sign_bit (niter.control.step) > 0) + niter.cmp = GT_EXPR; + else + niter.cmp = LT_EXPR; + } bbs = get_loop_body (loop1); |